Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex48 Add 2 new scenarios D75 and D76 using I13 for D71 and D74. Also remove some overlaps #32738

Merged
merged 2 commits into from Jan 29, 2021

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jan 25, 2021

PR description:

Add 2 new scenarios D75 and D76 using I13 for D71 and D74. Also remove some overlaps

PR validation:

Tested using overlap testing tools and runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32738/20886

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Geometry/CMSCommonData
Geometry/MTDCommonData

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32738/20888

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74297d/12527/summary.html
COMMIT: 6a28d01
CMSSW: CMSSW_11_3_X_2021-01-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32738/12527/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10978 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2716961
  • DQMHistoTests: Total failures: 125241
  • DQMHistoTests: Total nulls: 550
  • DQMHistoTests: Total successes: 2591148
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 156 log files, 37 edm output root files, 37 DQM output files

@kpedro88
Copy link
Contributor

@bsunanda was the overlap removal here expected to impact the older Phase 2 scenarios?

@bsunanda
Copy link
Contributor Author

@kpedro88 The overlaps were quite serious. Yes it will. Should I stop removing overlaps and make a new path only for the new scenarios?

@kpedro88
Copy link
Contributor

@bsunanda ultimately, what matters is the impact of these overlaps on physical results. If we still expect comparisons of new algorithms in 11_3_X to be valid for backporting those algorithms to 11_1_X (where we do not plan further updates to the D49 geometry), it is probably best to continue to fix D49 and other scenarios in the master branch.

@bsunanda
Copy link
Contributor Author

@kpedro88 OK - in that case I leave them as they are now with overlap fixed for the 2026 scenarios in the master branch

@srimanob
Copy link
Contributor

A question on overlap not sure I understand. If there is a large overlap between MUON and CALO, why did we miss them since D71 and D74 were added?

  • D71 = T21+C14+M7+I11+O7+F6
  • D74 = T21+C14+M9+I11+O7+F6

Do I miss a point here? Thanks very much @bsunanda @kpedro88

@bsunanda
Copy link
Contributor Author

Overlaps are cured by changing muonBase.xml used in O4, O5, O6, O7. So it will affect all 2026 scenarios including D71 and D74. The 2 new scenarios: D75, D76 use I13 instead of I11.

<Constant name="ETLrmax" value="[caloBase:Rmax100]"/> <!-- 125.525 cm -->
<Constant name="ETLthickness" value="7.7"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda thanks for updating that, there was a cleaning of v5 (I13) but not of this earlier version

@kpedro88
Copy link
Contributor

@bsunanda can you update the PR title?

@bsunanda bsunanda changed the title Phase2-gex48 Update the scenarios D71 and D74 with I13 and remove some overlaps Phase2-gex48 Add 2 new scenarios D75 and D76 using I13 for D71 and D74. Also remove some overlaps Jan 26, 2021
@cvuosalo
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

+Upgrade

@chayanit
Copy link

+1

@silviodonato
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants