New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex48 Add 2 new scenarios D75 and D76 using I13 for D71 and D74. Also remove some overlaps #32738
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32738/20886
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages: Configuration/Geometry @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @srimanob, @kpedro88 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32738/20888
|
Pull request #32738 was updated. @civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @srimanob, @qliphy, @fabiocos, @davidlange6 can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-74297d/12527/summary.html Comparison SummarySummary:
|
@bsunanda was the overlap removal here expected to impact the older Phase 2 scenarios? |
@kpedro88 The overlaps were quite serious. Yes it will. Should I stop removing overlaps and make a new path only for the new scenarios? |
@bsunanda ultimately, what matters is the impact of these overlaps on physical results. If we still expect comparisons of new algorithms in 11_3_X to be valid for backporting those algorithms to 11_1_X (where we do not plan further updates to the D49 geometry), it is probably best to continue to fix D49 and other scenarios in the master branch. |
@kpedro88 OK - in that case I leave them as they are now with overlap fixed for the 2026 scenarios in the master branch |
Overlaps are cured by changing muonBase.xml used in O4, O5, O6, O7. So it will affect all 2026 scenarios including D71 and D74. The 2 new scenarios: D75, D76 use I13 instead of I11. |
<Constant name="ETLrmax" value="[caloBase:Rmax100]"/> <!-- 125.525 cm --> | ||
<Constant name="ETLthickness" value="7.7"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bsunanda thanks for updating that, there was a cleaning of v5 (I13) but not of this earlier version
@bsunanda can you update the PR title? |
+1 |
+Upgrade |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Add 2 new scenarios D75 and D76 using I13 for D71 and D74. Also remove some overlaps
PR validation:
Tested using overlap testing tools and runTheMatrix test workflows
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special