Basic infrastructure for GEMs in CSC packer/unpacker #30167

dildick · 2020-06-09T23:15:08Z

PR description:

Basic infrastructure to pack and unpacker GEM clusters in the CSC packer/unpacker. Once the GEM-CSC is included in the TMB DAQ output data format, we can start filling in the blanks. The code does not do anything yet. There should be no changes in any of the workflows.

PR validation:

Tested with WF 27434.0

FYI @barvic

cmsbuild · 2020-06-09T23:15:29Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-09T23:20:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30167/15973

This PR adds an extra 44KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/CSCRawToDigi/interface/CSCDCCUnpacker.h modified in PR(s): added esConsumes to modules in EventFilter/CSCRawToDigi #30153
- File EventFilter/CSCRawToDigi/interface/CSCEventData.h modified in PR(s): Update accessor in CLCT and LCT data formats #30128
- File EventFilter/CSCRawToDigi/interface/CSCTMBHeader.h modified in PR(s): Update accessor in CLCT and LCT data formats #30128
- File EventFilter/CSCRawToDigi/plugins/CSCDCCUnpacker.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, added esConsumes to modules in EventFilter/CSCRawToDigi #30153, Update accessor in CLCT and LCT data formats #30128
- File EventFilter/CSCRawToDigi/plugins/CSCDigiToRawModule.cc modified in PR(s): added esConsumes to modules in EventFilter/CSCRawToDigi #30153
- File EventFilter/CSCRawToDigi/src/CSCDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/CSCRawToDigi/src/CSCEventData.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, Update accessor in CLCT and LCT data formats #30128, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-09T23:20:51Z

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

EventFilter/CSCRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

perrotta · 2020-06-10T06:21:38Z

@cmsbuild please test

cmsbuild · 2020-06-10T06:22:01Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6921/console Started: 2020/06/10 08:38

cmsbuild · 2020-06-10T09:08:00Z

-1

Tested at: bb83ad3

CMSSW: CMSSW_11_2_X_2020-06-09-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6214b/6921/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.793 step2

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step2_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

136.874 step2

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step2_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15_L1TMuDQM+HARVESTUP15_L1TMuDQM+NANOUP15.log

7.3 step2

runTheMatrix-results/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18/step2_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18.log

158.0 step2

runTheMatrix-results/158.0_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO/step2_HydjetQ_B12_5020GeV_2018_ppReco+HydjetQ_B12_5020GeV_2018_ppReco+DIGIHI2018PPRECO+RECOHI2018PPRECO+ALCARECOHI2018PPRECO+HARVESTHI2018PPRECO.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

23234.1001 step1

runTheMatrix-results/23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49/step1_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25+NANOUP15_PU25.log

11634.0 step2

runTheMatrix-results/11634.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2021_GenSimFull+DigiFull_2021+RecoFull_2021+HARVESTFull_2021+ALCAFull_2021.log

12434.0 step2

runTheMatrix-results/12434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2023_GenSimFull+DigiFull_2023+RecoFull_2023+HARVESTFull_2023+ALCAFull_2023/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+HARVESTFull_2017+ALCAFull_2017+NanoFull_2017.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log

10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU+NanoFull_2017PU.log

20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D35+RecoFullGlobal_2026D35+HARVESTFullGlobal_2026D35.log

20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D41_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D41+RecoFullGlobal_2026D41+HARVESTFullGlobal_2026D41.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D44_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D44+RecoFullGlobal_2026D44+HARVESTFullGlo/bin/sh:/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

23234.0 step2

runTheMatrix-results/23234.0_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49/step2_TTbar_14TeV+TTbar_14TeV_TuneCP5_2026D49_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D49+RecoFullGlobal_2026D49+HARVESTFullGlobal_2026D49.log

250202.181 step3

runTheMatrix-results/250202.181_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25/step3_TTbar_13UP18+TTbar_13UP18+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25.log

AddOn:

I found errors in the following addon tests:

AddOnTest might have timed out: FAILED - secs

cmsbuild · 2020-06-10T09:08:02Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2020-06-10T13:54:26Z

The code-checks are being triggered in jenkins.

dildick · 2020-06-10T13:57:43Z

This should fix it, but I will run a test (27434.0) to be sure.

cmsbuild · 2020-06-17T14:51:04Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-17T14:55:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30167/16205

This PR adds an extra 32KB to repository
Found files with invalid states:
- EventFilter/CSCRawToDigi/plugins/CSCDigiToPattern.h:
  - Added: b9c7b2e
  - Deleted: 0f3a46d
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/CSCRawToDigi/plugins/CSCDCCUnpacker.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
- File EventFilter/CSCRawToDigi/plugins/CSCDigiToPattern.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/CSCRawToDigi/plugins/CSCDigiValidator.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937
- File EventFilter/CSCRawToDigi/plugins/CSCViewDigi.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/CSCRawToDigi/plugins/DigiAnalyzer.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/CSCRawToDigi/src/CSCDigiToRaw.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936
- File EventFilter/CSCRawToDigi/src/CSCEventData.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

cmsbuild · 2020-06-17T14:56:14Z

Pull request #30167 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2020-06-17T15:11:57Z

please test

cmsbuild · 2020-06-17T15:12:20Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-16-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7147/console Started: 2020/06/17 17:19

cmsbuild · 2020-06-17T17:08:36Z

+1
Tested at: 81b8fd3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6214b/7147/summary.html
CMSSW: CMSSW_11_2_X_2020-06-16-2300
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Reduce boost dependency in AnalysisAlgos/SiStripClusterInfoProducer #30191 @camolezi: Reduce boost dependency in AnalysisAlgos/SiStripClusterInfoProducer
[Pixel 3D digitizer] Boundary row/col check in digitizer #30259 @duartej: [Pixel 3D digitizer] Boundary row/col check in digitizer
Reduce boost dependency in PhysicsTools/TagAndProbe #30229 @camolezi: Reduce boost dependency in PhysicsTools/TagAndProbe
Reduce boost dependency in PhysicsTools/MVAComputer #30227 @camolezi: Reduce boost dependency in PhysicsTools/MVAComputer
added esConsumes to modules in L1Trigger/TrackTrigger #30119 @JamminJones: added esConsumes to modules in L1Trigger/TrackTrigger
Hcal event setup tokenize #30207 @igv4321: Hcal event setup tokenize
skip complicated checks for PFCandidate-on-PFCandidate TopProjector #30071 @slava77: skip complicated checks for PFCandidate-on-PFCandidate TopProjector
Update accessor in CLCT and LCT data formats #30128 @dildick: Update accessor in CLCT and LCT data formats
Cleaning build files in Alignment #30261 @camolezi: Cleaning build files in Alignment

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6214b/7147/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6214b/7147/git-merge-result

cmsbuild · 2020-06-17T17:08:39Z

Comparison job queued.

cmsbuild · 2020-06-17T19:14:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e6214b/7147/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778757
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

perrotta · 2020-06-17T20:03:13Z

+1

Only rebased since Basic infrastructure for GEMs in CSC packer/unpacker #30167 (comment)
Added code intended to pack and unpack GEM clusters in the CSC packer/unpacker, which still does nothing while waiting for the GEM-CSC being included in the TMB DAQ output data format
Jenkis tests pass and show no differences, as expected

cmsbuild · 2020-06-17T20:03:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-06-17T20:14:13Z

+1

cmsbuild added this to the CMSSW_11_2_X milestone Jun 9, 2020

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 9, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 9, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 10, 2020

cmsbuild added comparison-notrun tests-rejected code-checks-pending comparison-pending tests-pending and removed comparison-pending tests-started code-checks-approved comparison-notrun tests-rejected labels Jun 10, 2020

cmsbuild added pending-signatures reconstruction-pending tests-pending labels Jun 17, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 17, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 17, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 17, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 17, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Jun 17, 2020

cmsbuild added orp-approved and removed orp-pending labels Jun 17, 2020

cmsbuild merged commit 17887b6 into cms-sw:master Jun 17, 2020

dildick deleted the from-CMSSW_11_2_X_2020-06-09-1100-GEM-infrastructure-CSC-packer branch June 17, 2020 20:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Basic infrastructure for GEMs in CSC packer/unpacker #30167

Basic infrastructure for GEMs in CSC packer/unpacker #30167

dildick commented Jun 9, 2020 •

edited

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

perrotta commented Jun 10, 2020

cmsbuild commented Jun 10, 2020 •

edited

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

dildick commented Jun 10, 2020 •

edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

perrotta commented Jun 17, 2020

cmsbuild commented Jun 17, 2020 •

edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

perrotta commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

silviodonato commented Jun 17, 2020

Basic infrastructure for GEMs in CSC packer/unpacker #30167

Basic infrastructure for GEMs in CSC packer/unpacker #30167

Conversation

dildick commented Jun 9, 2020 • edited

PR description:

PR validation:

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

cmsbuild commented Jun 9, 2020

perrotta commented Jun 10, 2020

cmsbuild commented Jun 10, 2020 • edited

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

cmsbuild commented Jun 10, 2020

dildick commented Jun 10, 2020 • edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

perrotta commented Jun 17, 2020

cmsbuild commented Jun 17, 2020 • edited

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

perrotta commented Jun 17, 2020

cmsbuild commented Jun 17, 2020

silviodonato commented Jun 17, 2020

dildick commented Jun 9, 2020 •

edited

cmsbuild commented Jun 10, 2020 •

edited

dildick commented Jun 10, 2020 •

edited

cmsbuild commented Jun 17, 2020 •

edited