-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force the definition of the USEHYBRID preprocessor symbol #30683
Conversation
The code-checks are being triggered in jenkins. |
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30683/16971
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: L1Trigger/TrackFindingTracklet @cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
urgent |
@skinnari FYI |
@cmsbuild, please test workflow 20434.0 for slc7_ppc64le_gcc820 |
The tests are being triggered in jenkins.
|
please test |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins.
|
Comparison is ready Comparison Summary:
|
+1 |
Comparison job queued. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
merge |
Comparison is ready The workflows 1001.0, 1000.0, 140.53, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Comparison Summary:
|
PR description:
Force the definition of the
USEHYBRID
preprocessor symbol in all the L1Trigger/TrackFindingTracklet BuildFiles.PR validation:
The code now seems to be running fine on a Power8 machine, where before it was crashing before the first event.