Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the definition of the USEHYBRID preprocessor symbol #30683

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jul 14, 2020

PR description:

Force the definition of the USEHYBRID preprocessor symbol in all the L1Trigger/TrackFindingTracklet BuildFiles.

PR validation:

The code now seems to be running fine on a Power8 machine, where before it was crashing before the first event.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 14, 2020

type bug-fix

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30683/16971

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

L1Trigger/TrackFindingTracklet

@cmsbuild, @rekovic, @benkrikler can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 14, 2020

urgent

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 14, 2020

@skinnari FYI

@fwyzard
Copy link
Contributor Author

fwyzard commented Jul 14, 2020

@cmsbuild, please test workflow 20434.0 for slc7_ppc64le_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020

The tests are being triggered in jenkins.
Test Parameters:

@rekovic
Copy link
Contributor

rekovic commented Jul 14, 2020

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 14, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01a778/7932/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787429
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2787378
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@cmsbuild
Copy link
Contributor

+1
Tested at: 8adf3d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01a778/7938/summary.html
CMSSW: CMSSW_11_2_X_2020-07-13-2300
SCRAM_ARCH: slc7_ppc64le_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor

rekovic commented Jul 15, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit a37165a into cms-sw:master Jul 15, 2020
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-01a778/7938/summary.html

The workflows 1001.0, 1000.0, 140.53, 136.88811, 136.874, 136.8311, 136.793, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 56311 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2787429
  • DQMHistoTests: Total failures: 676865
  • DQMHistoTests: Total nulls: 22
  • DQMHistoTests: Total successes: 2110492
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -7124.537 KiB( 36 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -259.963 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 1306.0,... ): -204.107 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 1325.7,... ): -204.104 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 136.731,... ): -204.115 KiB DQM/TimerService
  • DQMHistoSizes: changed ( 136.731,... ): 0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.793 ): -0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.874 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): -1.044 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.070 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 8.0 ): ...
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants