Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant include. #30948

Merged
merged 1 commit into from Jul 29, 2020
Merged

Remove redundant include. #30948

merged 1 commit into from Jul 29, 2020

Conversation

vgvassilev
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30948/17380

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vgvassilev (Vassil Vassilev) for master.

It involves the following packages:

TrackingTools/TransientTrack

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@trocino, @Fedespring, @folguera, @calderona, @makortel, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @JanFSchulte, @jhgoh, @VinInn, @bellan, @HuguesBrun, @rovere, @lecriste, @gpetruc, @ebrondol, @mtosi, @dgulhan, @cericeci this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 28, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: e57eb24
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53d8de/8377/summary.html
CMSSW: CMSSW_11_2_X_2020-07-28-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53d8de/8377/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53d8de/8377/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53d8de/8377/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 132 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525444
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 9
  • DQMHistoTests: Total successes: 2525383
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.152 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 10024.0,... ): 0.004 KiB MessageLogger/Warnings
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@perrotta
Copy link
Contributor

+1

  • Technical
  • Jenkins tests pass: comparisons with the baseline show differences only in TriggerResults variables corresponding to addition of a new filter path in the MET filter paths with addition of BadPFMuonFilter_Dz_cfi.py MET filter in CMSSW #30015, run together with this PR (this PR is so trivial that I see no need to re-run the tests to clean up the outputs)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants