Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean BuildFiles in PhysicsTools and some other subsystems #30873

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Clean BuildFiles in PhysicsTools and some other subsystems #30873

merged 1 commit into from
Jul 28, 2020

Conversation

guitargeek
Copy link
Contributor

PR description:

Another quick partially automatic BuildFile cleaning PR in the style of many before (for example #30679).

As always, only the dependencies which are not included in any of the sources are removed, so these changes are orthogonal and complementary to the recent PRs which added all packages that are actually included.

PR validation:

CMSSW compiles. It was checked that all newly added dependencies are actually required by the package with git grep.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30873/17240

  • This PR adds an extra 60KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

EgammaAnalysis/ElectronTools
ElectroWeakAnalysis/Skimming
ElectroWeakAnalysis/ZMuMu
HeavyFlavorAnalysis/Onia2MuMu
HeavyFlavorAnalysis/RecoDecay
HeavyFlavorAnalysis/SpecificDecay
HiggsAnalysis/HiggsToGammaGamma
HiggsAnalysis/Skimming
MagneticField/Engine
MagneticField/GeomBuilder
OnlineDB/SiStripConfigDb
PerfTools/Callgrind
PhysicsTools/CandAlgos
PhysicsTools/CondLiteIO
PhysicsTools/FWLite
PhysicsTools/IsolationAlgos
PhysicsTools/JetExamples
PhysicsTools/MXNet
PhysicsTools/NanoAOD
PhysicsTools/ONNXRuntime
PhysicsTools/PatAlgos
PhysicsTools/PatExamples
PhysicsTools/PatUtils
PhysicsTools/RecoAlgos
PhysicsTools/RecoUtils
PhysicsTools/SelectorUtils
PhysicsTools/TagAndProbe
PhysicsTools/TensorFlow
PhysicsTools/UtilAlgos
PhysicsTools/Utilities
RecoEgamma/Examples

@perrotta, @smuzaffar, @Dr15Jones, @makortel, @cmsbuild, @jpata, @gouskos, @fgolf, @slava77, @ggovi, @mariadalfonso, @santocch, @peruzzim can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @gouskos, @felicepantaleo, @jainshilpi, @schoef, @emilbols, @ahinzmann, @lgray, @peruzzim, @seemasharmafnal, @mmarionncern, @makortel, @smoortga, @varuns23, @jdolen, @hqucms, @ferencek, @Sam-Harper, @jdamgov, @nhanvtran, @gkasieczka, @hatakeyamak, @mmusich, @andrzejnovak, @clelange, @namapane, @riga, @JyothsnaKomaragiri, @mverzett, @sobhatta, @afiqaize, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jul 22, 2020

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 22, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 60ec1b0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e463f/8220/summary.html
CMSSW: CMSSW_11_2_X_2020-07-21-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8e463f/8220/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525996
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525948
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jul 23, 2020

+1

for #30873 60ec1b0

  • technical
  • jenkins tests pass

@mariadalfonso
Copy link
Contributor

+1

@santocch
Copy link

+1

@silviodonato
Copy link
Contributor

Do you have any objections?
core: @Dr15Jones @smuzaffar @makortel
db: @ggovi

@makortel
Copy link
Contributor

+1

@ggovi
Copy link
Contributor

ggovi commented Jul 28, 2020

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6c6c9d9 into cms-sw:master Jul 28, 2020
@guitargeek guitargeek deleted the BuildFiles_PhysicsTools_1 branch July 28, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants