Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move SiPhase2OuterTrackerLorentzAngleRcd to GlobalTag #31259

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Aug 27, 2020

PR description:

Now that #31095 is merged in a pre-release (CMSSW_11_2_0_pre5), the corresponding conditions for the reco and sim outer tracker Lorentz Angle SiPhase2OuterTrackerLorentzAngleRcd and SiPhase2OuterTrackerLorentzAngleSimRcd can be supplied directly from the Global Tag ESSource, in lieu of a separate ESProducer.
As the conditions are the same for all the currently supported Phase-2 Tracker Geometries, the new tags are included in the physical autoCond base GT for the key auto:phase2_realistic. If in future the values for different geometries need to diverge, these can be changed individually for each symbolic Global Tag in autoCondPhase2.
The Global Tag is at the moment a GT candidate, but can be changed to full-fledged GT if the AlCa/DB team can supply one, the difference in terms of tags is available here.
No physics changes are expected.

PR validation:

This branch passes the unit tests scramv1 b runtests as well as

runTheMatrix.py --what upgrade -l 23206.0,23606.0,24406.0,24806.0,26606.0,27006.0,27406.0,27806.0,28206.0,28606.0,29006.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport and no backport is needed.

attn: @trtomei

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31259/17930

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Configuration/AlCa
Configuration/Geometry

@civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @pohsun, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @tocheng, @Martin-Grunewald, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Aug 27, 2020

test parameters
workflows = 29434.0, 29834.0, 30234.0

@mmusich
Copy link
Contributor Author

mmusich commented Aug 27, 2020

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 1fb1318
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-785a7e/8951/summary.html
CMSSW: CMSSW_11_2_X_2020-08-26-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-785a7e/8951/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-785a7e/29434.0_TTbar_14TeV+2026D63+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-785a7e/29834.0_TTbar_14TeV+2026D64+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-785a7e/30234.0_TTbar_14TeV+2026D65+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609639
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Pull request #31259 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @christopheralanwest, @ianna, @mdhildreth, @cmsbuild, @tocheng, @tlampen, @pohsun, @kpedro88 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Aug 28, 2020

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 28, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: 7904911
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-785a7e/8980/summary.html
CMSSW: CMSSW_11_2_X_2020-08-27-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-785a7e/8980/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-785a7e/29434.0_TTbar_14TeV+2026D63+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-785a7e/29834.0_TTbar_14TeV+2026D64+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-785a7e/30234.0_TTbar_14TeV+2026D65+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609639
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@tlampen
Copy link
Contributor

tlampen commented Aug 28, 2020

+1

@cvuosalo
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Aug 29, 2020

+1

@cmsbuild cmsbuild merged commit fc6cdff into cms-sw:master Aug 29, 2020
@mmusich mmusich deleted the move_SiPhase2OuterTrackerLorentzAngle_to_GT branch August 29, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants