Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Make BeamSpotToCUDA constructible, and avoid building CUDADataFormats/BeamSpot when CUDA is not available according to cuda-gcc-support #31261

Closed
wants to merge 2 commits into from
Closed

[RFC] Make BeamSpotToCUDA constructible, and avoid building CUDADataFormats/BeamSpot when CUDA is not available according to cuda-gcc-support #31261

wants to merge 2 commits into from

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Aug 27, 2020 •
edited

PR description:

Attempt to fix a build failure in gcc10, and after that to make workflows to run.

PR validation:

Building CUDADataFormats/BeamSpot succeeds (i.e. gets skipped) on gcc10.

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Aug 27, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31261/17933

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CUDADataFormats/BeamSpot

@perrotta, @makortel, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

test parameters:

  • release slc7_amd64_gcc10

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2020 •
edited

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+1
Tested at: 8d4c9eb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c398b/8954/summary.html
CMSSW: CMSSW_11_2_X_2020-08-27-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c398b/8954/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2609639
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@makortel
Copy link
Contributor Author

test parameters:

  • release = slc7_amd64_gcc10

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

Comparison job queued.

@silviodonato silviodonato mentioned this pull request Aug 31, 2020
Merged
@fwyzard
Copy link
Contributor

fwyzard commented Aug 31, 2020

Ok, apparently in slc7_amd64_gcc10 clang-format prefers > > over >> for some reason.

Nope, it is not about the SCRAM_ARCH. Somehow clang-format gets confused by the #else...

Ah... OK, less worrying then.

@fwyzard
Copy link
Contributor

fwyzard commented Aug 31, 2020

On the other hand, is this really the approach we want to pursue for all CUDA plugins ?

I'd really like to find a different solution (despite of suggesting #ifdef in #28576 (comment)) for longer term. For now it might be the best we can do. I propose we discuss on this tomorrow in the core software meeting.

I remember... and unfortunately I don't have any other ideas at the moment.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c398b/9019/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 42111 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 347643
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 2261999
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.805 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -0.986 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.308 KiB SiStrip/MechanicalView
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@makortel makortel mentioned this pull request Sep 2, 2020
Merged
@perrotta
Copy link
Contributor

perrotta commented Sep 2, 2020

@cmsbuild, please test
(Last time it was tested with CMSSW_11_2_X_2020-08-28-2300, which did not include yet #31283: let check if the HI tests succeed now, first included in CMSSW_11_2_X_2020-08-31-2300)

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020 •
edited

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

+1
Tested at: cd6d44f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c398b/9066/summary.html
CMSSW: CMSSW_11_2_X_2020-09-01-2300
SCRAM_ARCH: slc7_amd64_gcc10

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

Comparison job queued.

@cmsbuild cmsbuild mentioned this pull request Sep 2, 2020
Merged
@makortel
Copy link
Contributor Author

makortel commented Sep 2, 2020

#31334 proposes an alternative by relaxing the pieces in CUDA utilities that can be built with just the host compiler (gcc) to be built with <iftool name="cuda"> instead of <iftool name="cuda-gcc-support">. We can make BeamSpotToCUDA to build and construct without any #ifdefs because no device code is called. Producers calling device still need some kind of protection (details to be figured out).

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c398b/9066/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 42068 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2609667
  • DQMHistoTests: Total failures: 347645
  • DQMHistoTests: Total nulls: 4
  • DQMHistoTests: Total successes: 2261996
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.801 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.127 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 250202.181 ): -0.986 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): 0.308 KiB SiStrip/MechanicalView
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@makortel
Copy link
Contributor Author

makortel commented Sep 4, 2020

Closing in favor of #31334

@makortel makortel closed this Sep 4, 2020
@makortel makortel mentioned this pull request May 25, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwyzard fwyzard fwyzard left review comments

Assignees
No one assigned
Labels
alca-pending code-checks-approved comparison-available heterogeneous-pending orp-pending pending-signatures reconstruction-pending tests-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@makortel @cmsbuild @smuzaffar @fwyzard @perrotta