Phase2-gex11 Add a scenario D66 and workflow 30634 with 16 strip GE21 #31451

bsunanda · 2020-09-13T02:02:17Z

PR description:

Add a scenario D66 and workflow 30634 with 16 strip GE21

PR validation:

Test using runTheMatrix using the workflow 30634.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2020-09-13T02:02:42Z

The code-checks are being triggered in jenkins.

bsunanda · 2020-09-13T02:04:12Z

@slomeo @watson-ij Just made a workflow still using ME0 for 16 strip GE21. Once this is accepted will make the one when GE0 replaces ME0

cmsbuild · 2020-09-13T02:08:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31451/18333

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/Geometry/python/dict2026Geometry.py modified in PR(s): update the tracking material for Phase2 geometry D49 #30126

cmsbuild · 2020-09-13T02:08:40Z

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
Geometry/CMSCommonData

@civanch, @Dr15Jones, @jordan-martins, @chayanit, @cvuosalo, @wajidalikhan, @ianna, @mdhildreth, @cmsbuild, @makortel, @franzoni, @silviodonato, @kpedro88, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2020-09-13T02:15:33Z

@cmsbuild Please test

cmsbuild · 2020-09-13T02:15:50Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-09-12-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9294/console Started: 2020/09/13 04:16

cmsbuild · 2020-09-13T03:27:55Z

+1
Tested at: d70c4f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05f346/9294/summary.html
CMSSW: CMSSW_11_2_X_2020-09-12-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-13T03:27:57Z

Comparison job queued.

cmsbuild · 2020-09-13T04:59:36Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-05f346/9294/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2620306
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2620283
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

mmusich · 2020-09-13T15:56:05Z

Configuration/Geometry/README.md

@@ -88,5 +88,6 @@ Several detector combinations have been generated:
 * D63 = T21+C11+M4+I11+O5+F4
 * D64 = T22+C11+M4+I11+O5+F4
 * D65 = T23+C11+M4+I11+O5+F4
+* D66 = T17+C11+M8+I11+O5+F4


@bsunanda T17 is soon to be decommissioned (next week). I would suggest to use T21 as new baseline instead of T17. @emiglior FYI

Changed T17 to T21

@mmusich while I agree for new scenarios it's better to use a more modern tracker, what is the intention for the 6 scenarios currently using T17 when it is "decommissioned"?

I suppose they should all be migrated to T21. @emiglior is preparing a PR about that.

Unless of course some other subsystem explicitly wants to keep T17 around.

Let's move to #30512

cmsbuild · 2020-09-18T15:14:03Z

The tests are being triggered in jenkins.
Tested with other pull request(s) #31507
Test Parameters:

MATRIX_EXTRAS = 30634.0
CMSSW_11_2_X_2020-09-18-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9429/console Started: 2020/09/18 17:14

cmsbuild · 2020-09-18T16:30:03Z

+1
Tested at: e8ea499
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c7c86/9429/summary.html
CMSSW: CMSSW_11_2_X_2020-09-18-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-09-18T16:30:10Z

Comparison job queued.

kpedro88 · 2020-09-18T16:31:38Z

+upgrade

dildick · 2020-09-18T16:35:58Z

Looks good. GEM warnings are gone. HGCal remain. From step2_TTbar_14TeV+2026D66+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal.log

18-Sep-2020 17:49:44 CEST  Initiating request to open file file:step1.root
18-Sep-2020 17:49:45 CEST  Successfully opened file file:step1.root
create data set info Default
create data set info Default
create data set info Default
create data set info Default
Begin processing the 1st record. Run 1, Event 1, LumiSection 1 on stream 0 at 18-Sep-2020 17:50:57.424 CEST
%MSG-w HGCalTriggerGeometry:  HGCalVFEProducer:hgcalVFEProducer  18-Sep-2020 17:51:08 CEST Run: 1 Event: 1
Found missing wafer (layer=35 u=1 v=1) in trigger modules mapping
%MSG
...
%MSG-w HGCalTriggerGeometry:  HGCalVFEProducer:hgcalVFEProducer  18-Sep-2020 17:52:43 CEST Run: 1 Event: 10
Found missing wafer (layer=35 u=3 v=-10) in trigger modules mapping
%MSG
18-Sep-2020 17:52:46 CEST  Closed file file:step1.root

=============================================

MessageLogger Summary

kpedro88 · 2020-09-18T16:37:01Z

Yes, I noticed the HGCal warnings earlier today and opened #31506. Those are unrelated to this PR.

cmsbuild · 2020-09-18T17:59:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1c7c86/9429/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1c7c86/30634.0_TTbar_14TeV+2026D66+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2540471
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2540442
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

bsunanda · 2020-09-18T18:09:37Z

@silviodonato Could you merge this PR?

silviodonato · 2020-09-18T21:11:10Z

+1

cmsbuild · 2020-09-18T21:11:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Add a scenario D66 and workflow 30634 with 16 strip GE21

d70c4f6

cmsbuild added this to the CMSSW_11_2_X milestone Sep 13, 2020

cmsbuild added code-checks-pending comparison-pending geometry-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Sep 13, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 13, 2020

cmsbuild added tests-started and removed tests-pending labels Sep 13, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 13, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 13, 2020

mmusich reviewed Sep 13, 2020

View reviewed changes

Change T17 to T21 in D66

e8ea499

cmsbuild added comparison-pending tests-pending and removed tests-approved labels Sep 18, 2020

cmsbuild added requires-external tests-started and removed tests-pending labels Sep 18, 2020

cmsbuild added tests-approved and removed tests-started labels Sep 18, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Sep 18, 2020

cmsbuild added comparison-available and removed comparison-pending labels Sep 18, 2020

cmsbuild mentioned this pull request Sep 18, 2020

HeavyIon Reaction Plane MiniAOD #31129

Merged

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending orp-pending pending-signatures labels Sep 18, 2020

cmsbuild merged commit b16771b into cms-sw:master Sep 18, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-gex11 Add a scenario D66 and workflow 30634 with 16 strip GE21 #31451

Phase2-gex11 Add a scenario D66 and workflow 30634 with 16 strip GE21 #31451

bsunanda commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

bsunanda commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

bsunanda commented Sep 13, 2020

cmsbuild commented Sep 13, 2020 •

edited

cmsbuild commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

mmusich Sep 13, 2020

bsunanda Sep 13, 2020

kpedro88 Sep 14, 2020

mmusich Sep 14, 2020

mmusich Sep 14, 2020

kpedro88 Sep 14, 2020

cmsbuild commented Sep 18, 2020 •

edited

cmsbuild commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

kpedro88 commented Sep 18, 2020

dildick commented Sep 18, 2020

kpedro88 commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

bsunanda commented Sep 18, 2020

silviodonato commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

Phase2-gex11 Add a scenario D66 and workflow 30634 with 16 strip GE21 #31451

Phase2-gex11 Add a scenario D66 and workflow 30634 with 16 strip GE21 #31451

Conversation

bsunanda commented Sep 13, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 13, 2020

bsunanda commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

bsunanda commented Sep 13, 2020

cmsbuild commented Sep 13, 2020 • edited

cmsbuild commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

cmsbuild commented Sep 13, 2020

mmusich Sep 13, 2020

Choose a reason for hiding this comment

bsunanda Sep 13, 2020

Choose a reason for hiding this comment

kpedro88 Sep 14, 2020

Choose a reason for hiding this comment

mmusich Sep 14, 2020

Choose a reason for hiding this comment

mmusich Sep 14, 2020

Choose a reason for hiding this comment

kpedro88 Sep 14, 2020

Choose a reason for hiding this comment

cmsbuild commented Sep 18, 2020 • edited

cmsbuild commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

kpedro88 commented Sep 18, 2020

dildick commented Sep 18, 2020

kpedro88 commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

bsunanda commented Sep 18, 2020

silviodonato commented Sep 18, 2020

cmsbuild commented Sep 18, 2020

cmsbuild commented Sep 13, 2020 •

edited

cmsbuild commented Sep 18, 2020 •

edited