Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex33 Also add cfg's for step4 and step5 to test dd4hep for Zmumu #32016

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Nov 3, 2020

PR description:

Also add cfg's for step4 and step5 to test dd4hep for Zmumu

PR validation:

test by running the workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

The code-checks are being triggered in jenkins.

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 3, 2020

@slomeo Here are the cfg's for step4 and step5 - they run without issues

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32016/19556

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2020

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

SimG4Core/Configuration

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Nov 4, 2020

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

+1
Tested at: 237dd08
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9245/10489/summary.html
CMSSW: CMSSW_11_2_X_2020-11-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3e9245/10489/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 2544092
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2544069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 149 log files, 22 edm output root files, 35 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 4, 2020

@bsunanda out of curiosity, what is this PR adding on top of #30003 and #31975 ?

@civanch
Copy link
Contributor

civanch commented Nov 5, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 80259a0 into cms-sw:master Nov 5, 2020
@slomeo
Copy link
Contributor

slomeo commented Nov 5, 2020

@bsunanda thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants