-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable ctppsProtons from recoCTPPSTask in Run-3 #33266
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33266/21757
|
A new Pull Request was created by @silviodonato (Silvio Donato) for master. It involves the following packages: RecoPPS/Configuration @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
I'm still getting
in step-3 of
From @fabferro's comment (#32356 (comment))
@cms-sw/alca-l2 @fabferro could you check what is missing? Thanks! |
Thye most up to date GT for the |
No. There are only four available tags with record type |
@christopheralanwest @mundim @fabferro @jan-kaspar please clarify on the status of having the right |
A recently uploaded tag, LHCInfo_2021_mc_v1, as the correct record type and the naming suggests that it is the needed tag. But AlCa hasn't received a request to include it in the 2021 GTs so we can't take any action yet. |
@mundim @fabferro @jan-kaspar the last open pre-release of 11_3_x is in one week from now. |
@malbouis @wpcarvalho : can you help to include LHCInfo in the GT?? |
My understand is that it still needs to be tested. However, I can ask it to be included in the GT, as it should have no "side effect" and is a light single payload tag. Please, let me know what AlCaDB experts think of this approach which may facilitate the tests. |
Hi @wpcarvalho! |
The tag
Run 3 scenarios assume sqrt(s) = 14 TeV so, assuming this value is intended to represent the energy per beam, it should be set to 7000. |
If 14 TeV is the CMS default, I think, we (PPS) should align with it. @wpcarvalho could you please update the tag? I can take care of providing a 14 TeV profile for the "direct" simulation. |
Sorry, this post went to my Spam folder. Tomorrow (April 8) I will provide a tag with correct energy and post a request in AlCa HN. |
For the "direct" simu part, I've just opened #33370 . |
I've just queued the tag |
test parameters:
|
please test |
-1 Failed Tests: RelVals AddOn RelVals
AddOn Tests
Expand to see more addon errors ... |
I guess that #33404 includes also the new Run3 geometry for PPS. In this case, tests only make sense with #33250. |
All three relevant PRs are included in the tests triggered for PR #33404: #33404 (comment) |
Right, #33250 was included for tests of #33404, but not for tests in this PR - this is what I wished to say. |
please test |
please test |
-1 Failed Tests: AddOn AddOn Tests
Expand to see more addon errors ...Comparison SummaryThe workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons @slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
This PR has been included in #33415 |
-1 |
After #33090, we are finally testing
GluGluTo2Jets_M_300_2000_14TeV_Exhume
(11725.0,11925.0
) in the IB tests (#32969). This workflow was added specifically to test the PPS reco (#32765).Brief summary of the history:
No 'LHCInfoRcd' record found in the EventSetup.n
(No "LHCInfoRcd" record found in the EventSetup.n (CTPPSProtonProducer/'ctppsProtons') #32340)LHCInfoRcd
has been added in the GT.Reverts #32352
@mundim @fabferro @jan-kaspar @cms-sw/alca-l2 @cms-sw/reconstruction-l2
PS. The last open pre-release of 11_3_X is scheduled on April 13.