Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing GluGluTo2Jets_M_300_2000_14TeV_Exhume_cff.py #32969

Merged
merged 2 commits into from Feb 23, 2021

Conversation

silviodonato
Copy link
Contributor

PR description:

There was some confusion between #32765 and #32868.
In the end #32868 was merged, it uses GluGluTo2Jets_M_300_2000_14TeV_Exhume_cff.py (from #32765) but it was not added.
This PR adds the missing file.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32969/21207

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @silviodonato (Silvio Donato) for master.

It involves the following packages:

Configuration/Generator

@SiewYan, @mkirsano, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@silviodonato
Copy link
Contributor Author

merge
bugfix, adding a file

@cmsbuild cmsbuild merged commit f75d51d into cms-sw:master Feb 23, 2021
@silviodonato
Copy link
Contributor Author

I just wanted to be included in the 11AM IB in order to prevent to have a failing workflow
@cms-sw/generators-l2 this fragment was already discussed in #32765

@silviodonato
Copy link
Contributor Author

please test workflows 11725.0,11925.0,11925.98,11925.99,12125.0,12325.0,12325.98,12325.99

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c7899/13039/summary.html
COMMIT: 8ed6801
CMSSW: CMSSW_11_3_X_2021-02-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/32969/13039/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

@agrohsje
Copy link

Hi @silviodonato , now you confused me. I am closely following #32765 but the fragment that is now merged here is different from 32765. It corresponds to the original one where I commented on outdated settings (this is now fixed in 32765). I didn't sign the other one yet, as still tests are failing but I am ok with the final settings. BUT this is different from the file here. Do I miss something?

@silviodonato
Copy link
Contributor Author

@agrohsje thanks for the check. You are right, at least d28934f is missing. I squashed the commits into one commit and solved the conflict, likely I've made some mistake, I'm sorry about that.
@mundim (or @agrohsje) could you open a PR with the fix?

@silviodonato
Copy link
Contributor Author

@agrohsje
I've tried again to squash and solve the conflict of #32765.
Does https://github.com/cms-sw/cmssw/compare/master...silviodonato:PPSRelValGenFragment_reb?expand=1
include the fix you are talking about?

@mundim
Copy link
Contributor

mundim commented Feb 24, 2021

@agrohsje thanks for the check. You are right, at least d28934f is missing. I squashed the commits into one commit and solved the conflict, likely I've made some mistake, I'm sorry about that.
@mundim (or @agrohsje) could you open a PR with the fix?

Hi @silviodonato. Thanks for your help but I got a bit confused. The other message was an attempt by yourself to solve it or should I issue a new PR anyway?
Thank you very much.

@silviodonato
Copy link
Contributor Author

Sorry for the confusion. You can use directly https://github.com/cms-sw/cmssw/compare/master...silviodonato:PPSRelValGenFragment_reb?expand=1
that should solve the problem, or I can open the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants