DTDQM migration to ESConsumes #33745

jfernan2 · 2021-05-15T10:56:11Z

PR description:

Following https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module

Fixes DT DQM modules for issue #31061

PR validation:

runTheMatrix.py -l limited -i all --ibeos

jfernan2 · 2021-05-15T10:57:53Z

please test

cmsbuild · 2021-05-15T11:03:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33745/22689

This PR adds an extra 16KB to repository

cmsbuild · 2021-05-15T11:03:35Z

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQM/DTMonitorClient
DQM/DTMonitorModule

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@battibass this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-05-15T13:20:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-536cb8/15115/summary.html
COMMIT: 130a3de
CMSSW: CMSSW_12_0_X_2021-05-14-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33745/15115/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648242
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2648207
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-05-20T08:28:39Z

please test

cmsbuild · 2021-05-20T08:37:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33745/22768

This PR adds an extra 16KB to repository

cmsbuild · 2021-05-20T08:38:07Z

Pull request #33745 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please check and sign again.

cmsbuild · 2021-05-20T11:26:37Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-536cb8/15204/summary.html
COMMIT: 161190c
CMSSW: CMSSW_12_0_X_2021-05-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33745/15204/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2648902
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2648873
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-05-20T20:08:32Z

+1

cmsbuild · 2021-05-20T20:08:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-05-21T08:08:33Z

+1

qliphy · 2021-05-22T00:11:59Z

@jfernan2 There are two untis failures from IB tests after including this PR
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_0_X_2021-05-21-1100/unitTestLogs/DQM/Integration#/1238-1238
Would you please have a check?

An exception of category 'ESGetTokenWrongTransition' occurred while
[0] Processing global begin Run run: 334393
[1] Calling method for module DTLocalTriggerLutTask/'dtTriggerLutMonitor'
Exception Message:
The transition ID stored in the ESGetToken does not match the
transition where the token is being used. The associated record
type is: MuonGeometryRecord

qliphy · 2021-05-22T14:25:47Z

DQM/DTMonitorModule/src/DTLocalTriggerLutTask.cc

@@ -31,7 +30,9 @@
 using namespace edm;
 using namespace std;

-DTLocalTriggerLutTask::DTLocalTriggerLutTask(const edm::ParameterSet& ps) : trigGeomUtils(nullptr) {
+DTLocalTriggerLutTask::DTLocalTriggerLutTask(const edm::ParameterSet& ps)
+    : muonGeomToken_(esConsumes(edm::ESInputTag("", ps.getUntrackedParameter<string>("geomLabel")))),


seems it should be
: muonGeomToken_(esConsumesedm::Transition::BeginRun()),

qliphy · 2021-05-22T14:26:34Z

DQM/DTMonitorClient/src/DTDataIntegrityTest.cc

@@ -24,7 +23,7 @@
 using namespace std;
 using namespace edm;

-DTDataIntegrityTest::DTDataIntegrityTest(const ParameterSet& ps) : nevents(0) {
+DTDataIntegrityTest::DTDataIntegrityTest(const ParameterSet& ps) : nevents(0), mappingToken_(esConsumes()) {


seems it should be
DTDataIntegrityTest::DTDataIntegrityTest(const ParameterSet& ps) : nevents(0), mappingToken_(esConsumesedm::Transition::EndLuminosityBlock()) {

jfernan2 · 2021-05-23T20:19:11Z

Thank you @qliphy
I have created PR #33819 fixing the issue, apologies for the mistake

@jfernan2 There are two untis failures from IB tests after including this PR
https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc900/CMSSW_12_0_X_2021-05-21-1100/unitTestLogs/DQM/Integration#/1238-1238
Would you please have a check?

An exception of category 'ESGetTokenWrongTransition' occurred while
[0] Processing global begin Run run: 334393
[1] Calling method for module DTLocalTriggerLutTask/'dtTriggerLutMonitor'
Exception Message:
The transition ID stored in the ESGetToken does not match the
transition where the token is being used. The associated record
type is: MuonGeometryRecord

jfernan2 added 2 commits May 15, 2021 12:51

Quotation marks in DTCalibValidation

cf7e907

Quotation marks in DTBlockedROChannelsTest

130a3de

cmsbuild added this to the CMSSW_12_0_X milestone May 15, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels May 15, 2021

cmsbuild added tests-started and removed tests-pending labels May 15, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 15, 2021

Quotation marks in header declrations

f3d2da8

cmsbuild added tests-approved and removed tests-started labels May 15, 2021

jfernan2 added 11 commits May 17, 2021 11:39

Typo

b89141c

Migration of DTCalibValidation

a453d5a

Migration of DTCalibValidationFromMuons

5f83933

Migration of DTDigiTask

678d612

Migration of DTEfficiencyTask

58fe671

Migration of DTChamberEfficiencyTask

869f7c4

Migration of DTLocalTriggerBaseTask

d0b0371

Migration of DTTriggerEfficiencyTask

14efc2e

Migration of DTLocalTriggerLutTask

6a5295a

Conversion of DTBlockedROChannelsTest

30b2496

Conversion of DTChamberEfficiencyClient

48ac314

cmsbuild added the tests-approved label May 18, 2021

Final migration of DTDAQInfo

161190c

cmsbuild added code-checks-pending tests-started and removed code-checks-approved tests-approved labels May 20, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 20, 2021

cmsbuild added tests-approved and removed tests-started labels May 20, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels May 20, 2021

cmsbuild added orp-approved and removed orp-pending labels May 21, 2021

cmsbuild merged commit f43c0b0 into cms-sw:master May 21, 2021

cmsbuild mentioned this pull request May 21, 2021

Utilities/StaticAnalyzers: use python3 in scripts #33813

Merged

qliphy reviewed May 22, 2021

View reviewed changes

jfernan2 mentioned this pull request May 23, 2021

[DT DQM] Fixes IB crash in DT DQM modules #33819

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DTDQM migration to ESConsumes #33745

DTDQM migration to ESConsumes #33745

jfernan2 commented May 15, 2021 •

edited

Loading

jfernan2 commented May 15, 2021

cmsbuild commented May 15, 2021

cmsbuild commented May 15, 2021

cmsbuild commented May 15, 2021

jfernan2 commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

jfernan2 commented May 20, 2021

cmsbuild commented May 20, 2021

silviodonato commented May 21, 2021

qliphy commented May 22, 2021

qliphy May 22, 2021

qliphy May 22, 2021

jfernan2 commented May 23, 2021

DTDQM migration to ESConsumes #33745

DTDQM migration to ESConsumes #33745

Conversation

jfernan2 commented May 15, 2021 • edited Loading

PR description:

PR validation:

jfernan2 commented May 15, 2021

cmsbuild commented May 15, 2021

cmsbuild commented May 15, 2021

cmsbuild commented May 15, 2021

Comparison Summary

jfernan2 commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

cmsbuild commented May 20, 2021

Comparison Summary

jfernan2 commented May 20, 2021

cmsbuild commented May 20, 2021

silviodonato commented May 21, 2021

qliphy commented May 22, 2021

qliphy May 22, 2021

Choose a reason for hiding this comment

qliphy May 22, 2021

Choose a reason for hiding this comment

jfernan2 commented May 23, 2021

jfernan2 commented May 15, 2021 •

edited

Loading