-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTDQM migration to ESConsumes #33745
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33745/22689
|
A new Pull Request was created by @jfernan2 for master. It involves the following packages: DQM/DTMonitorClient @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-536cb8/15115/summary.html Comparison SummarySummary:
|
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33745/22768
|
Pull request #33745 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @jfernan2, @rvenditti can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-536cb8/15204/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@jfernan2 There are two untis failures from IB tests after including this PR An exception of category 'ESGetTokenWrongTransition' occurred while |
@@ -31,7 +30,9 @@ | |||
using namespace edm; | |||
using namespace std; | |||
|
|||
DTLocalTriggerLutTask::DTLocalTriggerLutTask(const edm::ParameterSet& ps) : trigGeomUtils(nullptr) { | |||
DTLocalTriggerLutTask::DTLocalTriggerLutTask(const edm::ParameterSet& ps) | |||
: muonGeomToken_(esConsumes(edm::ESInputTag("", ps.getUntrackedParameter<string>("geomLabel")))), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it should be
: muonGeomToken_(esConsumesedm::Transition::BeginRun()),
@@ -24,7 +23,7 @@ | |||
using namespace std; | |||
using namespace edm; | |||
|
|||
DTDataIntegrityTest::DTDataIntegrityTest(const ParameterSet& ps) : nevents(0) { | |||
DTDataIntegrityTest::DTDataIntegrityTest(const ParameterSet& ps) : nevents(0), mappingToken_(esConsumes()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it should be
DTDataIntegrityTest::DTDataIntegrityTest(const ParameterSet& ps) : nevents(0), mappingToken_(esConsumesedm::Transition::EndLuminosityBlock()) {
Thank you @qliphy
|
PR description:
Following https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideHowToGetDataFromES#In_ED_module
Fixes DT DQM modules for issue #31061
PR validation:
runTheMatrix.py -l limited -i all --ibeos