Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed FWCore/ParameterSet dependecies from *Formats packages #33897

Merged
merged 6 commits into from
Jun 3, 2021
Merged

Removed FWCore/ParameterSet dependecies from *Formats packages #33897

merged 6 commits into from
Jun 3, 2021

Commits on May 30, 2021

  1. Include FileInPath.h from FWCore/Utilities in Formats packages 

    This is a step towards decreasing dependencies on FWCore/ParameterSet
in Formats packages.
    @Dr15Jones
    Dr15Jones committed May 30, 2021
    Configuration menu
    Copy the full SHA
    a5c98c7 View commit details
    Browse the repository at this point in the history

  2. Removed ParameterSet dependency from CSCReadoutMapping classes 

    This allowed removal of FWCore/ParameterSet dependency from
CondFormats/CSCObjects and some tests.
    @Dr15Jones
    Dr15Jones committed May 30, 2021
    Configuration menu
    Copy the full SHA
    f03754e View commit details
    Browse the repository at this point in the history

  3. Removed unnecessary includes in SiPixelQuality.cc 

    This allowed those dependencies to be dropped from BuildFile.xml.
    @Dr15Jones
    Dr15Jones committed May 30, 2021
    Configuration menu
    Copy the full SHA
    80a3f83 View commit details
    Browse the repository at this point in the history

  4. Removed comment out code

    @Dr15Jones
    Dr15Jones committed May 30, 2021
    Configuration menu
    Copy the full SHA
    c3194e9 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Added explicit dependency on FWCore/ParameterSet

    @Dr15Jones
    Dr15Jones committed May 31, 2021
    Configuration menu
    Copy the full SHA
    a67b13e View commit details
    Browse the repository at this point in the history

  2. Added missing includes

    @Dr15Jones
    Dr15Jones committed May 31, 2021
    Configuration menu
    Copy the full SHA
    0c333fc View commit details
    Browse the repository at this point in the history