Removed FWCore/ParameterSet dependecies from *Formats packages #33897

Dr15Jones · 2021-05-30T18:50:14Z

PR description:

Removed FWCore/ParameterSet dependencies from *Formats packages. As a general rule, no data products (ie. classes stored in *Formats subsystems) should have any dependency upon the framework itself, which includes how we configure the framework (i.e. the ParameterSet system).

This was prompted by the fact that the CXXMODULES IBs are failing because of ROOT's attempt to create a module from FWCore/ParameterSet. That failure caused many *Formats packages to also fail. If we remove the unnecessary dependency than we should be able to avoid having ROOT even attempt the parsing.

PR validation:

The code compiles.

This is a step towards decreasing dependencies on FWCore/ParameterSet in Formats packages.

This allowed removal of FWCore/ParameterSet dependency from CondFormats/CSCObjects and some tests.

This allowed those dependencies to be dropped from BuildFile.xml.

Dr15Jones · 2021-05-30T18:53:28Z

CondFormats/PhysicsToolsObjects/test/SiStripDeDx2DBuilder.cc

@@ -24,7 +24,7 @@ class SiStripDeDx2DBuilder : public edm::EDAnalyzer {
  virtual void analyze(const edm::Event&, const edm::EventSetup&);

 private:
-  edm::FileInPath fp_;
+  //edm::FileInPath fp_;


NOTE: this was left intentionally commented out as the code that uses fp_ was already commented out.

Dr15Jones · 2021-05-30T18:53:39Z

CondFormats/PhysicsToolsObjects/test/SiStripDeDx3DBuilder.cc

@@ -24,7 +24,7 @@ class SiStripDeDx3DBuilder : public edm::EDAnalyzer {
  virtual void analyze(const edm::Event&, const edm::EventSetup&);

 private:
-  edm::FileInPath fp_;
+  //edm::FileInPath fp_;


NOTE: this was left intentionally commented out as the code that uses fp_ was already commented out.

Dr15Jones · 2021-05-30T18:53:47Z

CondFormats/PhysicsToolsObjects/test/SiStripDeDxMipBuilder.h

@@ -22,7 +22,7 @@ class SiStripDeDxMipBuilder : public edm::EDAnalyzer {
  virtual void analyze(const edm::Event&, const edm::EventSetup&);

 private:
-  edm::FileInPath fp_;
+  //edm::FileInPath fp_;


NOTE: this was left intentionally commented out as the code that uses fp_ was already commented out.

cmsbuild · 2021-05-30T18:58:45Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33897/22960

ERROR: Build errors found during clang-tidy run.

Suppressed 507 warnings (506 in non-user code, 1 with check filters).
--
DataFormats/PatCandidates/src/CovarianceParameterization.cc:12:10: error: 'FWCore/Utilities/interface/FileInPath.h' file not found [clang-diagnostic-error]
#include "FWCore/Utilities/interface/FileInPath.h"
         ^
Suppressed 1134 warnings (1133 in non-user code, 1 with check filters).
--
CondFormats/SiPixelTransient/src/SiPixelTemplate2D.cc:41:10: error: 'FWCore/Utilities/interface/FileInPath.h' file not found [clang-diagnostic-error]
#include "FWCore/Utilities/interface/FileInPath.h"
         ^
Suppressed 508 warnings (507 in non-user code, 1 with check filters).
--
CondFormats/PPSObjects/src/PPSDirectSimulationData.cc:8:10: error: 'FWCore/Utilities/interface/FileInPath.h' file not found [clang-diagnostic-error]
#include "FWCore/Utilities/interface/FileInPath.h"
         ^
Suppressed 800 warnings (799 in non-user code, 1 with check filters).
--
CondFormats/SiPixelTransient/src/SiPixelTemplate.cc:107:10: error: 'FWCore/Utilities/interface/FileInPath.h' file not found [clang-diagnostic-error]
#include "FWCore/Utilities/interface/FileInPath.h"
         ^
Suppressed 507 warnings (506 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Dr15Jones · 2021-05-31T03:05:36Z

code-checks

cmsbuild · 2021-05-31T03:12:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33897/22965

This PR adds an extra 96KB to repository

cmsbuild · 2021-05-31T03:13:05Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CondFormats/CSCObjects
CondFormats/JetMETObjects
CondFormats/L1TObjects
CondFormats/PPSObjects
CondFormats/PhysicsToolsObjects
CondFormats/SiPixelObjects
CondFormats/SiPixelTransient
DataFormats/PatCandidates
EventFilter/CSCRawToDigi

@perrotta, @malbouis, @yuanchao, @jpata, @tlampen, @cmsbuild, @rekovic, @slava77, @ggovi, @pohsun, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @Martin-Grunewald, @OzAmram, @seemasharmafnal, @mmarionncern, @ahinzmann, @jdolen, @dildick, @barvic, @rovere, @VinInn, @jdamgov, @ferencek, @nhanvtran, @gkasieczka, @tocheng, @schoef, @mmusich, @ptcox, @clelange, @jan-kaspar, @dkotlins, @cbernet, @gpetruc, @mariadalfonso, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cecilecaillol · 2021-05-31T10:35:15Z

+l1

cmsbuild · 2021-05-31T16:11:51Z

Pull request #33897 was updated. @perrotta, @malbouis, @yuanchao, @jpata, @tlampen, @cmsbuild, @rekovic, @slava77, @ggovi, @pohsun, @cecilecaillol, @francescobrivio can you please check and sign again.

Dr15Jones · 2021-05-31T16:12:14Z

please test

cmsbuild · 2021-05-31T19:25:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c2aa7/15479/summary.html
COMMIT: 0c333fc
CMSSW: CMSSW_12_0_X_2021-05-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33897/15479/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9c2aa7/15479/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2650486
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2650463
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

ggovi · 2021-05-31T21:17:28Z

+1

cecilecaillol · 2021-06-01T15:02:58Z

+l1

slava77 · 2021-06-02T03:03:50Z

+reconstruction

for #33897 0c333fc

changes in reco are technical
there are no differences in comparisons

yuanchao · 2021-06-02T16:57:55Z

+1

removed FWCore/ParameterSet dependencies from *Formats packages
matrix tests and unit tests passed

cmsbuild · 2021-06-02T16:58:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-03T00:26:03Z

+1

Dr15Jones added 3 commits May 30, 2021 11:42

Include FileInPath.h from FWCore/Utilities in Formats packages

a5c98c7

This is a step towards decreasing dependencies on FWCore/ParameterSet in Formats packages.

Removed ParameterSet dependency from CSCReadoutMapping classes

f03754e

This allowed removal of FWCore/ParameterSet dependency from CondFormats/CSCObjects and some tests.

Removed unnecessary includes in SiPixelQuality.cc

80a3f83

This allowed those dependencies to be dropped from BuildFile.xml.

cmsbuild added this to the CMSSW_12_0_X milestone May 30, 2021

cmsbuild added alca-pending code-checks-pending db-pending l1-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 30, 2021

Removed comment out code

c3194e9

Dr15Jones commented May 30, 2021

View reviewed changes

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 30, 2021

cmsbuild added code-checks-pending and removed code-checks-rejected labels May 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2021

cmsbuild added l1-approved tests-started and removed l1-pending tests-pending tests-started labels May 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2021

cmsbuild added tests-started and removed tests-pending labels May 31, 2021

cmsbuild mentioned this pull request May 31, 2021

Removed unnecessary includes in CalibFormats/*Objects #33913

Merged

cmsbuild added tests-approved and removed tests-started labels May 31, 2021

cmsbuild added db-approved and removed db-pending labels May 31, 2021

cmsbuild added l1-approved and removed l1-pending labels Jun 1, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 2, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jun 2, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 3, 2021

cmsbuild merged commit 1ae7916 into cms-sw:master Jun 3, 2021

Dr15Jones deleted the fixParameterSetDepsInFormats branch June 3, 2021 19:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed FWCore/ParameterSet dependecies from *Formats packages #33897

Removed FWCore/ParameterSet dependecies from *Formats packages #33897

Dr15Jones commented May 30, 2021

Dr15Jones May 30, 2021

Dr15Jones May 30, 2021

Dr15Jones May 30, 2021

cmsbuild commented May 30, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

cecilecaillol commented May 31, 2021

cmsbuild commented May 31, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

ggovi commented May 31, 2021

cecilecaillol commented Jun 1, 2021

slava77 commented Jun 2, 2021

yuanchao commented Jun 2, 2021

cmsbuild commented Jun 2, 2021

qliphy commented Jun 3, 2021

Removed FWCore/ParameterSet dependecies from *Formats packages #33897

Removed FWCore/ParameterSet dependecies from *Formats packages #33897

Conversation

Dr15Jones commented May 30, 2021

PR description:

PR validation:

Dr15Jones May 30, 2021

Choose a reason for hiding this comment

Dr15Jones May 30, 2021

Choose a reason for hiding this comment

Dr15Jones May 30, 2021

Choose a reason for hiding this comment

cmsbuild commented May 30, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

cecilecaillol commented May 31, 2021

cmsbuild commented May 31, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

Comparison Summary

ggovi commented May 31, 2021

cecilecaillol commented Jun 1, 2021

slava77 commented Jun 2, 2021

yuanchao commented Jun 2, 2021

cmsbuild commented Jun 2, 2021

qliphy commented Jun 3, 2021