New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate module configurations in RecoTracker{ConversionSeedGenerators,DeDx} to use default cfipython #33901
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33901/22971
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages: RecoTracker/ConversionSeedGenerators @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a36320/15473/summary.html Comparison SummarySummary:
|
Addition to "do not print SiStrip O2O passwords in clear" cms-sw#33900 cms-sw#33900 prevents SiStripConfigDb.cc (https://github.com/cms-sw/cmssw/blob/CMSSW_12_0_DEVEL_X/OnlineDB/SiStripConfigDb/src/SiStripConfigDb.cc#L124) from printing passwd_ as part of confdb_ in line 314 in SiStripDbParams.cc
…6-09-2300-Remove-duplicate-CLCTs-LCTs Remove duplicate CLCTs and LCTs from trigger path in L1T CSC DQM
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33901/23255 ERROR: Build errors found during clang-tidy run.
|
PR description:
Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations.
In this PR, 3 files changed.
(The previous PRs were PR#33207, PR#33307, PR#33352, PR#33543, PR#33563, PR#33671 )
Updates:
Replace explicit configuration with a reference from cfipython/. (migrating EDProducer("type", .. -> typeDefault.clone())
Remove the type specifications already presented in cfipython/fillDescriptions reference for improved syntax safety.
Remove the duplicated parameters that are exactly the same value in cfipython reference.
PR validation:
Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_11_3_X, the basic test all passed in the CMSSW PR instructions.