Removed unnecessary includes in CalibFormats/*Objects #33913

Dr15Jones · 2021-05-31T14:03:00Z

PR description:

Removed unnecessary includes from FWCore/Framework.

PR validation:

Code compiles.

cmsbuild · 2021-05-31T14:08:17Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33913/22981

This PR adds an extra 12KB to repository

cmsbuild · 2021-05-31T14:08:40Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

CalibFormats/CastorObjects
CalibFormats/HcalObjects

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @abdoulline, @tocheng this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2021-05-31T14:34:47Z

please test

cmsbuild · 2021-05-31T14:51:07Z

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15465/summary.html
COMMIT: bad537e
CMSSW: CMSSW_12_0_X_2021-05-30-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33913/15465/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

Fix prodlike workflow to use DIGI instead of DIGI:pdigi_valid #33847 @srimanob: Fix prodlike workflow to use DIGI instead of DIGI:pdigi_valid
Use better interfaces to Geant4 #33894 @civanch: Use better interfaces to Geant4
Code-cleanup of RPC-DQM #33854 @jhgoh: Code-cleanup of RPC-DQM

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15465/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15465/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaECALRecHitReducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/AlCaElectronTracksReducer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/PUDumper.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc: In static member function 'static void SelectedElectronFEDListProducer::fillDescriptions(edm::ConfigurationDescriptions&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc:719:32: error: 'desc' has incomplete type
  719 |   edm::ParameterSetDescription desc;
      |                                ^~~~
In file included from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw/CMSSW_12_0_X_2021-05-30-2300/src/FWCore/Framework/interface/stream/EDProducer.h:24,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.h:11,
                 from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-30-2300/src/Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc:1:

cmsbuild · 2021-05-31T16:43:23Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33913/22990

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Calibration/EcalAlCaRecoProducers/plugins/SelectedElectronFEDListProducer.cc modified in PR(s): Removed FWCore/ParameterSet dependecies from *Formats packages #33897

cmsbuild · 2021-05-31T16:44:17Z

Pull request #33913 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio can you please check and sign again.

Dr15Jones · 2021-05-31T17:08:01Z

please test

cmsbuild · 2021-05-31T17:21:46Z

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15482/summary.html
COMMIT: a5198a2
CMSSW: CMSSW_12_0_X_2021-05-31-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33913/15482/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe6192/15482/llvm-analysis/cmsclangtidy.txt for details.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFMuonUntagger.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFPileUp.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PdgIdPFCandidateSelector.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PtMinPFCandidateSelector.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc: In static member function 'static void PFCandidateRecalibrator::fillDescriptions(edm::ConfigurationDescriptions&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc:308:32: error: aggregate 'edm::ParameterSetDescription desc' has incomplete type and cannot be defined
  308 |   edm::ParameterSetDescription desc;
      |                                ^~~~
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_0_X_2021-05-31-1100/src/CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc:310:25: error: expected primary-expression before '>' token
  310 |   desc.add("pfcandidates", edm::InputTag("particleFlow"));
      |                         ^

slava77 · 2021-06-04T03:12:14Z

+reconstruction

reco changes are somewhat trivial additions of missing direct includes in CommonTools/ParticleFlow/plugins/PFCandidateRecalibrator.cc

srimanob · 2021-06-04T03:22:56Z

+Upgrade

cecilecaillol · 2021-06-04T07:30:19Z

+l1

yuanchao · 2021-06-04T15:05:25Z

+1

civanch · 2021-06-04T21:02:02Z

+1

qliphy · 2021-06-07T00:39:27Z

kindly ping @cms-sw/db-l2

Dr15Jones · 2021-06-08T13:51:05Z

Ping @cms-sw/db-l2

ggovi · 2021-06-08T18:33:17Z

+1

cmsbuild · 2021-06-08T18:33:38Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-06-09T00:25:25Z

+1

cmsbuild added this to the CMSSW_12_0_X milestone May 31, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels May 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2021

cmsbuild added tests-started and removed tests-pending labels May 31, 2021

cmsbuild added tests-rejected code-checks-pending tests-pending and removed tests-started code-checks-approved tests-rejected labels May 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels May 31, 2021

cmsbuild added tests-started and removed tests-pending labels May 31, 2021

cmsbuild added tests-rejected and removed tests-started labels May 31, 2021

cmsbuild added the tests-approved label Jun 3, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jun 4, 2021

cmsbuild added l1-approved and removed l1-pending labels Jun 4, 2021

cmsbuild added alca-approved and removed alca-pending labels Jun 4, 2021

cmsbuild added simulation-approved and removed simulation-pending labels Jun 4, 2021

cmsbuild mentioned this pull request Jun 6, 2021

Introduce Quality for PixelTracks. Improve Patatrack duplicate & ambiguity resolution #33889

Merged

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Jun 8, 2021

cmsbuild added orp-approved and removed orp-pending labels Jun 9, 2021

cmsbuild merged commit 7207b0d into cms-sw:master Jun 9, 2021

cmsbuild mentioned this pull request Jun 9, 2021

initialize all of pat Muon sim info #34056

Merged

Dr15Jones deleted the removeIncludesCalibFormatsObjects branch June 9, 2021 14:37

cmsbuild mentioned this pull request Jun 9, 2021

Use LFN instead of hardcoded cms-xrd-global site #34057

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed unnecessary includes in CalibFormats/*Objects #33913

Removed unnecessary includes in CalibFormats/*Objects #33913

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

slava77 commented Jun 4, 2021

srimanob commented Jun 4, 2021

cecilecaillol commented Jun 4, 2021

yuanchao commented Jun 4, 2021

civanch commented Jun 4, 2021

qliphy commented Jun 7, 2021

Dr15Jones commented Jun 8, 2021

ggovi commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

qliphy commented Jun 9, 2021

Removed unnecessary includes in CalibFormats/*Objects #33913

Removed unnecessary includes in CalibFormats/*Objects #33913

Conversation

Dr15Jones commented May 31, 2021

PR description:

PR validation:

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

Build

cmsbuild commented May 31, 2021

cmsbuild commented May 31, 2021

Dr15Jones commented May 31, 2021

cmsbuild commented May 31, 2021

Build

slava77 commented Jun 4, 2021

srimanob commented Jun 4, 2021

cecilecaillol commented Jun 4, 2021

yuanchao commented Jun 4, 2021

civanch commented Jun 4, 2021

qliphy commented Jun 7, 2021

Dr15Jones commented Jun 8, 2021

ggovi commented Jun 8, 2021

cmsbuild commented Jun 8, 2021

qliphy commented Jun 9, 2021