-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Post-#3211 cleanup (MuonRoadTrajectoryBuilder, configuration files) #3446
Conversation
Running these with python produces errors indicating that they're not used in any standard workflow and that probably they have been skipped in some migration (maybe MeasurementTrackerEvent?). The configurations RecoPixelVertexing/PixelLowPtUtilities/python/MinBiasTracking_cff.py RecoPixelVertexing/PixelLowPtUtilities/python/common_cff.py RecoPixelVertexing/PixelLowPtUtilities/python/firstStep_cff.py do not have problems as such, but are related to (and only to) secondStep_cff.py and thirdStep_cff.py, which do have problems.
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X. Post-#3211 configuration file cleanup It involves the following packages: RecoMuon/L3TrackFinder @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
Hold off for a short while, I'll add another #3211 related cleanup to this PR. |
It is unused, extremely unlikely to be used in the future, and it is currently the only TrajectoryBuilder-deriving class constructed by ESProducer.
No more TrajectoryBuilder ESProducts
Removed MuonRoadTrajectoryBuilder as unnecessary, and removed TrajectoryBuilder from the set of ESProducts as MuonRoadTrajectoryBuilder was last TrajectoryBuilder ESProduct. I'll update the PR name and description. The PR is now (again) ready for tests and review. |
Reco -- Post-#3211 cleanup (MuonRoadTrajectoryBuilder, configuration files)
Following the merge of #3211, remove
All of the above (except
MinBiasTracking_cff.py
,common_cff.py
, andfirstStep_cff.py
) produce errors if run withpython file.py
indicating they're not used in any standard workflows (@cerati gave +1 for removing them). Removal ofsecondStep_cff.py
andthirdStep_cff.py
would makeMinBiasTracking_cff.py
erroneous, andcommon_cff.py
andfirstStep_cff.py
are imported only inMinBiasTracking_cff.py
so I removed them as well.