Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-#3211 cleanup (MuonRoadTrajectoryBuilder, configuration files) #3446

Merged
merged 5 commits into from
Apr 24, 2014

Conversation

makortel
Copy link
Contributor

Following the merge of #3211, remove

  • MuonRoadTrajectoryBuilder (not needed, confirmed by @trocino)
    • As a result, removed TrajectoryBuilder from the set of ESProducts
  • Obsolete CkfTrajectoryBuilder ESProducer configuration files
  • Obsolete TrajectoryFilter ESProducer configuration files
  • Bunch of other obsolete configuration files
RecoParticleFlow/PFTracking/python/convBrem_cff.py
RecoPixelVertexing/PixelLowPtUtilities/python/MinBiasTracking_cff.py
RecoPixelVertexing/PixelLowPtUtilities/python/common_cff.py
RecoPixelVertexing/PixelLowPtUtilities/python/firstStep_cff.py
RecoPixelVertexing/PixelLowPtUtilities/python/secondStep_cff.py
RecoPixelVertexing/PixelLowPtUtilities/python/thirdStep_cff.py
RecoTracker/ConversionSeedGenerators/python/PhotonConversionTrajectorySeedProducerFromQuadruplets_cff.py
RecoTracker/ConversionSeedGenerators/python/PhotonConversionTrajectorySeedProducerFromSingleLeg_cff.py
RecoTracker/ConversionSeedGenerators/python/PhotonConversionTrajectorySeedProducerFromSingleLeg_gsf_cff.py
RecoTracker/IterativeTracking/python/LargeD0_PixelPairStep_cff.py
RecoTracker/IterativeTracking/python/LargeD0_PixelTibTidTecStep_cff.py
RecoTracker/IterativeTracking/python/LargeD0_PixelTripletStep_cff.py
RecoTracker/IterativeTracking/python/LargeD0_TibTidTecStep_cff.py
RecoTracker/IterativeTracking/python/LargeD0_TobTecStep_cff.py

All of the above (except MinBiasTracking_cff.py, common_cff.py, and firstStep_cff.py) produce errors if run with python file.py indicating they're not used in any standard workflows (@cerati gave +1 for removing them). Removal of secondStep_cff.py and thirdStep_cff.py would make MinBiasTracking_cff.py erroneous, and common_cff.py and firstStep_cff.py are imported only in MinBiasTracking_cff.py so I removed them as well.

Running these with python produces errors indicating that they're not
used in any standard workflow and that probably they have been skipped
in some migration (maybe MeasurementTrackerEvent?).

The configurations
RecoPixelVertexing/PixelLowPtUtilities/python/MinBiasTracking_cff.py
RecoPixelVertexing/PixelLowPtUtilities/python/common_cff.py
RecoPixelVertexing/PixelLowPtUtilities/python/firstStep_cff.py
do not have problems as such, but are related to (and only to)
secondStep_cff.py and thirdStep_cff.py, which do have problems.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_7_1_X.

Post-#3211 configuration file cleanup

It involves the following packages:

RecoMuon/L3TrackFinder
RecoParticleFlow/PFTracking
RecoPixelVertexing/PixelLowPtUtilities
RecoTracker/CkfPattern
RecoTracker/ConversionSeedGenerators
RecoTracker/IterativeTracking
TrackingTools/TrajectoryFiltering

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @lgray, @gpetruc, @cerati, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@makortel
Copy link
Contributor Author

Hold off for a short while, I'll add another #3211 related cleanup to this PR.

It is unused, extremely unlikely to be used in the future, and it is
currently the only TrajectoryBuilder-deriving class constructed by
ESProducer.
No more TrajectoryBuilder ESProducts
@makortel
Copy link
Contributor Author

Removed MuonRoadTrajectoryBuilder as unnecessary, and removed TrajectoryBuilder from the set of ESProducts as MuonRoadTrajectoryBuilder was last TrajectoryBuilder ESProduct. I'll update the PR name and description. The PR is now (again) ready for tests and review.

@cmsbuild
Copy link
Contributor

Pull request #3446 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

@makortel makortel changed the title Post-#3211 configuration file cleanup Post-#3211 cleanup (MuonRoadTrajectoryBuilder, configuration files) Apr 23, 2014
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Apr 24, 2014

+1

for #3446 0e3c801

tested in CMSSW_7_1_X_2014-04-23-0200
(test area sign352)
no regressions observed on short matrix tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

nclopezo added a commit that referenced this pull request Apr 24, 2014
Reco -- Post-#3211 cleanup (MuonRoadTrajectoryBuilder, configuration files)
@nclopezo nclopezo merged commit ef36529 into cms-sw:CMSSW_7_1_X Apr 24, 2014
@makortel makortel deleted the cleanup3211 branch October 20, 2016 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants