New cluster processor for GEM-CSC trigger

[dildick]

PR description:

In this PR I add a GEMClusterProcessor that converts GEMPadDigiCluster to GEMInternalCluster: an interface that takes care of the GEM-to-CSC coordinate transformation and knows if it's a single cluster or a coincidence cluster. This will replace the GEMCoPadProcessor in the next PR. The CSCGEMMatcher was extended with the "COSI" (consistency of slope index) mechanism, to check that the GEM-CSC bending angle corresponds to the CSC internal slope. This will be used in the GEM-CSC matching soon. The quality assignment and quality control classes were extended to be used with GEMInternalCluster.

There are few other minor updates.

• A function in CSCMotherboard was made pass-by-ref instead of pass by value
• LUT generators produce missing index columns and missing headers

Requires cms-data/L1Trigger-CSCTriggerPrimitives#10

In the next PR I should finally remove CSCUpgradeMotherboard, and absorb CSCGEMMotherboardME11 and CSCGEMMotherboardME21 into CSCGEMMotherboard. Ultimately there should be two motherboards remaining (CSCMotherboard and CSCGEMMotherboard) down from 6. I'll also remove GEMCoPadProcessor and CSCUpgradeMotherboardLUT.

PR validation:

Run WF 11634.0. There shouldn't be changes in any WFs.

11634.0_TTbar_14TeV+2021+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Thu Jul 15 23:04:56 2021-date Thu Jul 15 22:41:31 2021; exit: 0 0 0 0 0
1 1 1 1 1 tests passed, 0 0 0 0 0 failed

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34513/24011

• This PR adds an extra 68KB to repository

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

• L1Trigger/CSCTriggerPrimitives (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[dildick]

@rathjd fyi

[cecilecaillol]

please test with cms-data/L1Trigger-CSCTriggerPrimitives#10

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1ee5aa/16883/summary.html
COMMIT: 98d952a
CMSSW: CMSSW_12_0_X_2021-07-15-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34513/16883/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2786302
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2786273
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[dildick]

Thanks @cecilecaillol. Just 7 failures, 6 from messagelogger, 1 from pixel.

[dildick]

Other than that, it looks good for me.

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[dildick]

@qliphy Can you sign off, please?

[qliphy]

@cms-sw/l1-l2 Please also check and sign cms-data/L1Trigger-CSCTriggerPrimitives#10

[qliphy]

+1