Fix rare crash in pixel template interpolation

[OzAmram]

This PR is a bugfix to address issue #34835. The crash was caused by a call to SiPixelTemplate2D::interpolate which had NaN track angles as inputs. The fix is just to check that the track angles are finite before proceeding with the interpolation. A similar change was applied to SiPixelTemplate::interpolate to avoid the potential for the same issue.

No changes are expected except for the extremely rare case when the input track angles are NaN's.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34846/24637

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @OzAmram (Oz Amram) for master.

It involves the following packages:

• CondFormats/SiPixelTransient (db, reconstruction)

@ggovi, @perrotta, @cmsbuild, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @seemasharmafnal, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[tvami]

type bugfix

[tvami]

Fixes #34835

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-04ec47/17712/summary.html
COMMIT: 19ed713
CMSSW: CMSSW_12_1_X_2021-08-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34846/17712/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2999391
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34846 19ed713

• code changes are in line with the PR description and the discussion in Segfault in data processing #34835
• jenkins tests pass and comparisons with the baseline show no differences

[perrotta]

@OzAmram can you prepare a backport for 12_0_X?
@cms-sw/db-l2 do you have any comment?

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• While it would be preferable trying to understand why those pathological inputs are fed into SiPixelTemplate2D::interpolate and trying to adjust at that level, this fix is nonetheless effective at avoiding those rare crashes while in run