[10_6_X] Fix rare crash in pixel template interpolation

[mmusich]

backport of #34846

PR description:

This PR is a bugfix to address issue #34835. The crash was caused by a call to SiPixelTemplate2D::interpolate which had NaN track angles as inputs. The fix is just to check that the track angles are finite before proceeding with the interpolation. A similar change was applied to SiPixelTemplate::interpolate to avoid the potential for the same issue.
No changes are expected except for the extremely rare case when the input track angles are NaN's.

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #34846

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_6_X.

It involves the following packages:

• CondFormats/SiPixelTransient (db, reconstruction)

@ggovi, @perrotta, @cmsbuild, @jpata, @slava77 can you please review it and eventually sign? Thanks.
@VinInn, @OzAmram, @ferencek, @mmusich, @dkotlins, @seemasharmafnal, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fix rare crash in pixel template interpolation #34846

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3aa46/17801/summary.html
COMMIT: c9d97af
CMSSW: CMSSW_10_6_X_2021-08-15-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34889/17801/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215350
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[ggovi]

+1

[cmsbuild]

Pull request #34889 was updated. @ggovi, @perrotta, @cmsbuild, @jpata, @slava77 can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d3aa46/17835/summary.html
COMMIT: 7de83da
CMSSW: CMSSW_10_6_X_2021-08-15-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34889/17835/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34889 7de83da

• code changes in this backport are the same as in the original PR Fix rare crash in pixel template interpolation #34846, which was merged two days ago. Based on Segfault in data processing #34835 (comment), I'm guessing that this is likely to become a "nice to have" fix, since the data with a crash will likely not be reprocessed (and most of the UL processing is supposedly already assigned to the older release campaigns).
• jenkins tests pass and comparisons with the baseline show no relevant differences

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1