[DBG] Fixes needed for 08-12-2300 DBG IB

[smuzaffar]

These fixes are needed for DBG IBs. https://github.com/cms-sw/cmssw/compare/master...smuzaffar:dbg-fix210812?expand=1#diff-4903b0b37950830325ac9459ce58d81069f5361ab58e9183276e83f3810b5822L594-L597 was commented out but 1d50112#diff-4903b0b37950830325ac9459ce58d81069f5361ab58e9183276e83f3810b5822L595 enabled it and placed it under EDM_ML_DEBUG condition but this does not compile. Please suggest a valid statement to replace it or remove it.

[smuzaffar]

@bsunanda , this code was initially commented out but your PR #34737 enabled it and placed it under EDM_ML_DEBUG. Looks like this code does not compile, please suggest the correct code to replace it or we can just remove it

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34874/24677

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34874/24677/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34874/24677/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34874/24681

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• Calibration/HcalCalibAlgos (alca)
• SimG4CMS/Forward (simulation)
• SimG4CMS/Tracker (simulation)

@malbouis, @civanch, @yuanchao, @mdhildreth, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@cvuosalo, @rovere, @bsunanda, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d20f9/17778/summary.html
COMMIT: 3de4e2b
CMSSW: CMSSW_12_1_X_2021-08-13-1700/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34874/17778/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999397
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[yuanchao]

+1

• fixed debug message handling (technical)
• matrix tests and build tests passed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1