Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DBG] Fixes needed for 08-12-2300 DBG IB #34874

Merged
merged 2 commits into from
Aug 16, 2021
Merged

[DBG] Fixes needed for 08-12-2300 DBG IB #34874

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a9b99a
[DBG] Fixes needed for 08-12-2300 DBG IB
smuzaffar Aug 13, 2021
3de4e2b
code-format
smuzaffar Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 0 additions & 4 deletions Calibration/HcalCalibAlgos/test/GammaJetAnalysis.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -591,10 +591,6 @@ void GammaJetAnalysis::analyze(const edm::Event& iEvent, const edm::EventSetup&

edm::Ref<reco::PhotonCollection> photonRef(photons, photon_tag.idx());
HERE(Form("got photon ref, photon_tag.idx()=%d", photon_tag.idx()));
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("GammaJetAnalysis")
<< "loosePhotonQual->at(photon_tag.idx())=" << loosePhotonQual->at(photon_tag.idx());
#endif
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda , this code was initially commented out but your PR #34737 enabled it and placed it under EDM_ML_DEBUG. Looks like this code does not compile, please suggest the correct code to replace it or we can just remove it

tagPho_idLoose_ = (loosePhotonQual.isValid()) ? (*loosePhotonQual)[photonRef] : -1;
tagPho_idTight_ = (tightPhotonQual.isValid()) ? (*tightPhotonQual)[photonRef] : -1;
} else {
Expand Down
10 changes: 5 additions & 5 deletions SimG4CMS/Forward/src/ZdcSD.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,12 @@ double ZdcSD::getEnergyDeposit(const G4Step* aStep) {
d_qz = th_arcos / twopi;
d_qz = std::abs(d_qz);
#ifdef EDM_ML_DEBUG
edm::LogVerbatim("ForwardSim").testOut << " d_qz: " << r << "," << a << "," << d << " " << tan_arcos << " "
edm::LogVerbatim("ForwardSim") << " d_qz: " << r << "," << a << "," << d << " " << tan_arcos << " "
<< arg_arcos;
edm::LogVerbatim("ForwardSim").testOut << "," << arg_arcos;
edm::LogVerbatim("ForwardSim").testOut << " " << d_qz;
edm::LogVerbatim("ForwardSim").testOut << " " << th_arcos;
edm::LogVerbatim("ForwardSim").testOut << "," << d_qz;
edm::LogVerbatim("ForwardSim") << "," << arg_arcos;
edm::LogVerbatim("ForwardSim") << " " << d_qz;
edm::LogVerbatim("ForwardSim") << " " << th_arcos;
edm::LogVerbatim("ForwardSim") << "," << d_qz;
#endif
}
}
Expand Down
2 changes: 1 addition & 1 deletion SimG4CMS/Tracker/src/TrackerG4SimHitNumberingScheme.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void TrackerG4SimHitNumberingScheme::touchToNavStory(const G4VTouchable* v,
}
}
#ifdef EDM_ML_DEBUG
LogDebug("TrackerSimDebugNumbering") << " G4 TrackerG4SimHitNumberingScheme " << debugint;
LogDebug("TrackerSimDebugNumbering") << " G4 TrackerG4SimHitNumberingScheme " << debugint.size();
for (u_int32_t jj = 0; jj < debugstring.size(); jj++)
LogDebug("TrackerSimDebugNumbering") << " " << debugstring[jj];
#endif
Expand Down