Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GCC11] Fix warning: 'result' is used uninitialized #35040

Closed
wants to merge 2 commits into from

Conversation

iarspider
Copy link
Contributor

@iarspider iarspider commented Aug 27, 2021

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-24-0900/SimDataFormats/DigiSimLinks

.../src/SimDataFormats/DigiSimLinks/src/DTDigiSimLink.cc: In member function 'DTDigiSimLink::ChannelType DTDigiSimLink::channel() const':
  .../src/SimDataFormats/DigiSimLinks/src/DTDigiSimLink.cc:29:11: warning: 'result' is used uninitialized [-Wuninitialized]
    29 |   return *p_result;
      |           ^~~~~~~~
.../src/SimDataFormats/DigiSimLinks/src/DTDigiSimLink.cc:25:18: note: 'result' declared here
   25 |   ChannelPacking result;
      |                  ^~~~~~

@iarspider
Copy link
Contributor Author

please test for slc7_amd64_gcc11

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35040/24901

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35040/24902

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @iarspider for master.

It involves the following packages:

  • SimDataFormats/DigiSimLinks (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@sscruz, @fabiocos, @Fedespring, @battibass, @trocino, @apsallid, @abbiendi, @JanFSchulte, @jhgoh, @VinInn, @bsunanda, @HuguesBrun, @rovere, @lecriste, @calderona, @mmusich, @mtosi, @ebrondol, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@iarspider
Copy link
Contributor Author

please test for slc7_amd64_gcc11

@cmsbuild
Copy link
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c49580/18078/summary.html
COMMIT: f7aecef
CMSSW: CMSSW_12_1_X_2021-08-25-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35040/18078/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c49580/18078/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c49580/18078/git-merge-result

Build

I found compilation warning when building: See details on the summary page.

@iarspider iarspider closed this Aug 27, 2021
@iarspider
Copy link
Contributor Author

As far as I can tell, it's a false-positive.

@iarspider iarspider deleted the patch-2 branch August 28, 2021 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants