Run3-gex90 Make unique material names as default for all Run3 scenarios

[bsunanda]

PR description:

Make unique material names as default for all Run3 scenarios

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34983/24825

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/Geometry/python/dict2021Geometry.py modified in PR(s): [DD4hep] Revise order of materials to prevent delayed resolution of references #34974

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa06a7/17971/summary.html
COMMIT: 78e336b
CMSSW: CMSSW_12_1_X_2021-08-23-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34983/17971/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[cvuosalo]

@bsunanda Could you change an additional line in Configuration/Geometry/python/dict2021Geometry.py? As in my PR #34974, change:
''Geometry/TrackerCommonData/data/PhaseI/v2/pixbarmaterial.xml', to'Geometry/TrackerCommonData/data/PhaseI/v3/pixbarmaterial.xml', `
for "T3".
Then I can remove this change from #34974.
After that, we merge #34974 first, followed by this PR.

[bsunanda]

OK - I shall do that

…

________________________________ From: Carl Vuosalo ***@***.*** Sent: 23 August 2021 21:16 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-gex90 Make unique material names as default for all Run3 scenarios (#34983) @bsunanda<https://github.com/bsunanda> Could you change an additional line in Configuration/Geometry/python/dict2021Geometry.py? As in my PR #34974<#34974>, change: ''Geometry/TrackerCommonData/data/PhaseI/v2/pixbarmaterial.xml', to'Geometry/TrackerCommonData/data/PhaseI/v3/pixbarmaterial.xml', ` for "T3". Then I can remove this change from #34974<#34974>. After that, we merge #34974<#34974> first, followed by this PR. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#34983 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOTVVH2BWOALWK4UMDLT6KNBDANCNFSM5CUYVG2Q>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.

[bsunanda]

@cvuosalo Can I also take the v3/pixbarmaterial.xml. Without that the PR won't be complete

[bsunanda]

@cvuosalo So you need to remove the changes in dict2021geometry.py and remove the addition to pixbarmaterial.xml

[bsunanda]

@cvuosalo Please confirm

[bsunanda]

@cvuosalo Or I can take your advice that let your PR get merged and then I can get this PR tested

[civanch]

@bsunanda , @cvuosalo, I think that #34974 should be merged first, at least, this would be an ideal sequence.

[bsunanda]

@cvuosalo I shall take your and Vladimir's comments. I shall only change dict2021 and create the scenaruos. I am not triggering the tests till your PR gets merged.

…

________________________________ From: Vladimir Ivantchenko ***@***.*** Sent: 23 August 2021 23:42 To: cms-sw/cmssw Cc: Sunanda Banerjee; Mention Subject: Re: [cms-sw/cmssw] Run3-gex90 Make unique material names as default for all Run3 scenarios (#34983) @bsunanda<https://github.com/bsunanda> , @cvuosalo<https://github.com/cvuosalo>, I think that #34974<#34974> should be merged first, at least, this would be an ideal sequence. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#34983 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABGMZOR4SSGMPF2QVDDGTYDT6K6EBANCNFSM5CUYVG2Q>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>.

[civanch]

urgent

[bsunanda]

@cmsbuild Please test

[bsunanda]

@civanch @perrotta @qliphy I tested against the latest IB and I think it is OK

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa06a7/18001/summary.html
COMMIT: 28b3036
CMSSW: CMSSW_12_1_X_2021-08-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34983/18001/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[civanch]

@perrotta, @qliphy tests are fine, would it possible to merge it without upgrade sign - @srimanob is aware about this PR but he may have problem to access these days.

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1