Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filling and multiplicity ranges #35129

Merged
merged 2 commits into from Sep 3, 2021

Conversation

ptcox
Copy link
Contributor

@ptcox ptcox commented Sep 2, 2021

Two simple set of changes to CSC DQM sub package that examines digis, rechits, and segments:
i) Fix two mis-filled simple efficiency histograms - bins didn't match x-axis labels (CSC chamber ring labels)
ii) Split overall strip and wire digi, and rechit multiplicity plots into two, one with 'standard' range and with 'extended' range for high multiplicities seen in phase2 PU200 simulations. I've adjusted the 'standard' ranges and binning so that the overall number of bins is slightly reduced so there is no increase in resource usage.

PR validation:

Validated on several runs with 250 events of run3 TTbar workflow using
runTheMatrix.py -l 11634.0 --command="-n 250"

scram b code-format shows no suggestions for change.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35129/25033

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

A new Pull Request was created by @ptcox for master.

It involves the following packages:

  • DQMOffline/Muon (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @barvic, @bellan, @abbiendi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0230b2/18266/summary.html
COMMIT: e8ce7f3
CMSSW: CMSSW_12_1_X_2021-09-02-1600/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35129/18266/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 118
  • DQMHistoTests: Total nulls: 116
  • DQMHistoTests: Total successes: 3000148
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -15.515 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -0.535 KiB CSC/CSCOfflineMonitor
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 3, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 3, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants