New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filling and multiplicity ranges #35129
Fix filling and multiplicity ranges #35129
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35129/25033
|
A new Pull Request was created by @ptcox for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0230b2/18266/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Two simple set of changes to CSC DQM sub package that examines digis, rechits, and segments:
i) Fix two mis-filled simple efficiency histograms - bins didn't match x-axis labels (CSC chamber ring labels)
ii) Split overall strip and wire digi, and rechit multiplicity plots into two, one with 'standard' range and with 'extended' range for high multiplicities seen in phase2 PU200 simulations. I've adjusted the 'standard' ranges and binning so that the overall number of bins is slightly reduced so there is no increase in resource usage.
PR validation:
Validated on several runs with 250 events of run3 TTbar workflow using
runTheMatrix.py -l 11634.0 --command="-n 250"
scram b code-format shows no suggestions for change.