Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the TriggerResultsFilter default configuration to skip the current process #35131

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Sep 2, 2021

PR description:

The default configuration of TriggerResultsFilter tries to read the TriggerResults without specifying any process label, which is understood as wanting to read from the current process.
This leads to test for the TriggerResultsFilter failing because of a conflict in the schedule.

This PR updates the default configuration to ignore the current process.

PR validation:

HLTrigger/HLTfilters/test/triggerResultsFilter.py now works:

cmsRun HLTrigger/HLTfilters/test/triggerResultsFilter_producer.py
...
cmsRun HLTrigger/HLTfilters/test/triggerResultsFilter.py
...
TrigReport ---------- Path   Summary ------------
TrigReport  Trig Bit#   Executed     Passed     Failed      Error Name
TrigReport     1    0       1000        500        500          0 path_1
TrigReport     1    1       1000        333        667          0 path_2
TrigReport     1    2       1000        200        800          0 path_3
TrigReport     1    3       1000         33        967          0 path_all_explicit
TrigReport     1    4       1000        733        267          0 path_any_or
TrigReport     1    5       1000       1000          0          0 path_any_star
TrigReport     1    6       1000         33        967          0 path_1_pre
TrigReport     1    7       1000         33        967          0 path_2_pre
TrigReport     1    8       1000         99        901          0 path_any_pre
TrigReport     1    9       1000       1000          0          0 path_any_doublestar
TrigReport     1   10       1000        733        267          0 path_any_question
TrigReport     1   11       1000          0       1000          0 path_wrong_name
TrigReport     1   12       1000          0       1000          0 path_wrong_pattern
TrigReport     1   13       1000       1000          0          0 path_not_wrong_pattern
TrigReport     1   14       1000          0       1000          0 path_empty_pattern
TrigReport     1   15       1000          0       1000          0 path_l1path_pattern
TrigReport     1   16       1000          0       1000          0 path_l1singlemuopen_pattern
TrigReport     1   17       1000       1000          0          0 path_true_pattern
TrigReport     1   18       1000          0       1000          0 path_false_pattern

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2021

please test

@fwyzard
Copy link
Contributor Author

fwyzard commented Sep 2, 2021

type bugfix

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35131/25037

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HLTrigger/HLTfilters (hlt)

@Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35131/25049

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b11db7/18278/summary.html
COMMIT: 6da6f5a
CMSSW: CMSSW_12_1_X_2021-09-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35131/18278/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000382
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 3, 2021

+1

@cmsbuild cmsbuild merged commit ea5d8dd into cms-sw:master Sep 3, 2021
@fwyzard fwyzard deleted the fix_TriggerResultsFilter_skipCurrentProcess branch July 31, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants