Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSC TP efficiency producer in standard Validation sequence #35135

Merged
merged 1 commit into from Sep 5, 2021
Merged

Add CSC TP efficiency producer in standard Validation sequence #35135

merged 1 commit into from Sep 5, 2021

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Sep 2, 2021

PR description:

We noticed that the efficiencies for the CSC TP efficiencies were not being added in the Validation step. There is an occupancy directory with denominators and numerators. There should be an efficiency directory with plots as well, but clearly it's not there. This PR fixes that.

Screen Shot 2021-09-02 at 12 49 09 PM

Denominators and numerators

Screen Shot 2021-09-02 at 12 51 46 PM

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35135/25042

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

  • Validation/Configuration (dqm, simulation)
  • Validation/MuonCSCDigis (dqm)

@civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @rvenditti can you please review it and eventually sign? Thanks.
@apsallid, @ebrondol, @rovere, @lecriste this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 2, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cd4869/18267/summary.html
COMMIT: 8624ff3
CMSSW: CMSSW_12_1_X_2021-09-02-1600/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35135/18267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3000404
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000376
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 235.416 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): 13.848 KiB MuonCSCDigisV/CSCDigiTask
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Sep 3, 2021

+1

@dildick
Copy link
Contributor Author

dildick commented Sep 3, 2021

@civanch Do you have any comments?

@civanch
Copy link
Contributor

civanch commented Sep 5, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 5, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 5, 2021

+1

@cmsbuild cmsbuild merged commit d4bc4ea into cms-sw:master Sep 5, 2021
@dildick dildick deleted the from-CMSSW_12_1_X_2021-09-02-1100-csc-tp-efficiency branch September 8, 2021 16:13
@dildick dildick changed the title Add CSC TP efficiency producer in standard DQM sequence Add CSC TP efficiency producer in standard Validation sequence Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants