Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] Updates on validation scripts #35239

Merged
merged 2 commits into from Sep 14, 2021

Conversation

apsallid
Copy link
Contributor

PR description:

With the opportunity of the HGCAL V16 material budget study and the ongoing 12_1_0_pre2_Phase2_D76 RelVal campaign, we update the following:

  1. The latest menu for the webpage including RelVal campaigns and updated geometry section.
  2. The html.py script with a tweak in the name of a RelVal sample.
  3. The main validation script hgcalPerformanceValidation.py with a directory creation to make our life easier in the material budget study.
  4. The config script used for the material budget study including all detectors from vertex up to in front of muon stations.
  5. The plot_hgcal_utils.py script, since with the removal of the CALOECTSMiddle Volume, the CALOECTSFront contains now the EndcapTimingLayer, the Neutron Moderator and the Thermal Screen, which we wish to split.

PR validation:

We have used these scripts to perform the 12_1_0_pre2_Phase2_D76 campaign validation and the HGCAL V16 material budget study.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport.

@rovere @felicepantaleo @lecriste @ebrondol

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35239/25205

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @apsallid for master.

It involves the following packages:

  • Validation/Geometry (geometry, dqm)
  • Validation/HGCalValidation (dqm)

@civanch, @Dr15Jones, @kmaeshima, @cvuosalo, @andrius-k, @mdhildreth, @ianna, @cmsbuild, @makortel, @jfernan2, @ahmad3213, @ErnestaP, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @vargasa, @rovere, @lgray, @cseez, @bsunanda, @pfs, @lecriste, @hatakeyamak, @ebrondol, @rishabhCMS, @fabiocos, @rbartek this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fcf95b/18540/summary.html
COMMIT: 829d8d3
CMSSW: CMSSW_12_1_X_2021-09-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35239/18540/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000979
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cvuosalo
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Sep 14, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants