Add logic in OnlineBeamSpotESProducer [12_0_X]

[francescobrivio]

PR description:

Backport of #35333: adds a real logic in OnlineBeamSpotESProducer in order to discriminate between the two BeamSpot workflows. This is needed for the Pilot Beam Test at the end of October.

PR validation:

Tested locally using RecoVertex/BeamSpotProducer/test/test_scalars.py.

Backport:

Backport of #35333

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_0_X.

It involves the following packages:

• RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Add logic in OnlineBeamSpotESProducer #35333

[francescobrivio]

backport of #35333

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8f4c15/18738/summary.html
COMMIT: 13aecbd
CMSSW: CMSSW_12_0_X_2021-09-19-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35334/18738/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998530
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

[tvami]

@francescobrivio should we add an urgent label? Since it should be included in the next 12_0_X release?

[francescobrivio]

urgent

[cmsbuild]

Pull request #35334 was updated. @malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @francescobrivio, @tvami can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[mmusich]

see a possible solution at #35373

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

hold

• waiting for backport of fix offline BS swap for express Run3 #35373 to be merged

[cmsbuild]

Pull request has been put on hold by @francescobrivio
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[mmusich]

@francescobrivio @tvami #35373 needs more work. In particular an update of the Run3 MC Global Tags might be in order. I propose to unhold and merge this that is already signed.

[francescobrivio]

unhold

• given the comment in Add logic in OnlineBeamSpotESProducer [12_0_X] #35334 (comment)

[francescobrivio]

+alca

@qliphy @perrotta this is fully signed and can be merged at you convenience!

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[mmusich]

hello, is there anything preventing the merge of this?
It is needed in order to prepare also the backport of #35373 (which is a mandatory patch for the test beam)

[perrotta]

+1

• The very same logic already merged in master is implemented in this backport
• It will need the further merging of (the backport of) fix offline BS swap for express Run3 #35373 in order to be usable for the test runs