-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix offline BS swap for express Run3 #35373
Conversation
type bug-fix |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35373/25451
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@perrotta, @malbouis, @yuanchao, @davidlange6, @cmsbuild, @slava77, @jpata, @qliphy, @francescobrivio, @fabiocos, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
3955f88
to
9bca3e1
Compare
I realized that the inclusion of BeamSpotESProducer = cms.ESProducer("OnlineBeamSpotESProducer") in |
@mmusich is this still a draft? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35373/25454
|
+Upgrade |
+1 |
+Upgrade For the upgrade part, update to the defined GT on DD4hep. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Address discussion at #35334 (comment).
PR validation:
Run successfully wf 138.2 with:
runTheMatrix.py -l 138.2 -j 8 -t 4
and verified the configuration looks as it should:if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, but a backport to 12_0_X is needed.