finalize esConsumes for RecoTracker/SpecialSeedGenerators

[mmusich]

PR description:

In response to #35258 (comment)
Part of #31061

PR validation:

It compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35367/25445

• This PR adds an extra 24KB to repository

[mmusich]

@cmsbuild, please test

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• RecoTracker/SpecialSeedGenerators (reconstruction)

@jpata, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5274d2/18823/summary.html
COMMIT: 9b9f864
CMSSW: CMSSW_12_1_X_2021-09-21-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35367/18823/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211058
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35367/25503

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoTracker/SpecialSeedGenerators/interface/CosmicRegionalSeedGenerator.h modified in PR(s): Migrate TrackingRegions to esConsumes #35393
  • File RecoTracker/SpecialSeedGenerators/src/CosmicRegionalSeedGenerator.cc modified in PR(s): Migrate TrackingRegions to esConsumes #35393

[cmsbuild]

Pull request #35367 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

[mmusich]

please test

[slava77]

@cmsbuild please test

it looks like the last attempt got stuck

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5274d2/18908/summary.html
COMMIT: 4915cb6
CMSSW: CMSSW_12_1_X_2021-09-24-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35367/18908/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211052
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[mmusich]

ping?

[slava77]

Suggested change

	matchedrecHitsToken_ = consumes<SiStripMatchedRecHit2DCollection>(conf.getParameter<edm::InputTag>("matchedRecHits"));
	matchedrecHitsToken_ = consumes(conf.getParameter<edm::InputTag>("matchedRecHits"));

the type is not needed anymore.
Perhaps it's more practical to do a more general purge of this old style consumes call in a separate PR.

[slava77]

+reconstruction

for #35367 4915cb6

• code changes are essentially technical, in line with the PR title/description and the follow up review
  • here and elsewhere some cleanup along convert old style of consumes/esConsumes/produces calls to use the new style with automatic type deduction #34981 may be nice
• jenkins tests pass and comparisons with the baseline show no relevant differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[Dr15Jones]

@mmusich thanks!