-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for PPS geometry on Pixel sensors and materials #35346
Conversation
Now pass in the necessary ES data product.
Now pass in the needed EventSetup data products.
Possibly missing #include
When the gpu modifier is enabled, make the Pixel, ECAL and HCAL reconstruction offloadable to a GPU.
Simplify the Pixel local reconstruction running on GPU, taking advatage of cms-sw#34259.
…eoFix121pre2 rebasing into CMSSW_12_1_X_2021-09-21-2300
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35346/25464
|
Pull request #35346 was updated. @SiewYan, @jpata, @lveldere, @bbilin, @wajidalikhan, @slava77, @ianna, @Saptaparna, @Martin-Grunewald, @rekovic, @alberto-sanchez, @cecilecaillol, @perrotta, @civanch, @yuanchao, @makortel, @ahmad3213, @cmsbuild, @missirol, @agrohsje, @GurpreetSinghChahal, @smorovic, @davidlange6, @smuzaffar, @Dr15Jones, @cvuosalo, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @kskovpen, @sbein, @ggovi, @qliphy, @pmandrik, @fabiocos, @pbo0, @francescobrivio, @malbouis, @ssekmen, @mkirsano, @jordan-martins, @emeschi, @srimanob, @rvenditti, @tvami can you please check and sign again. |
@diemort , you did something wrong. Better to close this and create a new PR on top of the recent IB, where include only your modifications. |
-alca
|
PR description:
This PR addresses a few minor corrections on the PPS geometry in the Pixel sensors and complies the material names in the reco geometry as stated in #34927. The position of the Silicon wafers has been move down to 250um w.r.t. the bottom foil and the envelopes with sensors ad flexible cables has been enlarged to avoid volume overlaps. Besides, the U shape of the Aluminum supports has been changed to a plain squared piece. A detailed list of the file changes and visualization of the new changes in the Pixel sensors is given in this twiki.
Includes updated on both DDD and dd4hep files as well as a new entry in dict2021Geometry.py named P7 with the latest geometry XML files.
PR validation:
The new changes in the geometry have been validated with the full CMS geometry dump for visualization and overlap check with tolerance 0.01, plus direct and full simulation to confirm hits in both pixel and timing detectors.
All changes follow the Naming Rules for new XML files in geometry.
All workflow tests done.
FYI @fabferro