Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include final 2021 MC DD4HEP geometry tags + new 2021 design MC beamspot GT #35514

Merged
merged 2 commits into from Oct 3, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Oct 3, 2021

PR description:

DD4HEP change

Include final 2021 MC DD4HEP geometry tags using the new autoCond modifier method. The new tags are explicitly visible in the code change, but for completeness they include

tag: XMLFILE_Geometry_121DD4hepV1_Extended2021_mc 
label: Extended

and

tag: TKRECO_Geometry_121DD4hepV1

as requested in [1]

[1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4475.html

New 2021 design MC beamspot GT

The second part of this PR is to include a new record introduced in [2] in the 2021 design MC as it was realized earlier that it was not created, see the comment [3]. The HN request can be found under [4].

The new GT and the diff wrt to the prev versioned GT are

They differ only in the requested tags:

  | BeamSpotOnlineHLTObjectsRcd | - | - | BeamSpotOnlineObjects_Ideal_Centered_SLHC_v3_mc
  | BeamSpotOnlineLegacyObjectsRcd | - | - | BeamSpotOnlineObjects_Ideal_Centered_SLHC_v3_mc

[2] #35373
[3] #35478 (comment)
[4] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4474/3.html

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is not a backport but a backport to 12_0_X for the beamspot part is expected.

cc: @cms-sw/geometry-l2 @srimanob

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35514/25720

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@yuanchao, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

test parameters:

  • workflows = 12034.0,11634.912

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19345/summary.html
COMMIT: da7a5c0
CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19345/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 03-Oct-2021 03:09:50 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

-1

Failed Tests: RelVals Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19345/summary.html COMMIT: da7a5c0 CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19345/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 03-Oct-2021 03:09:50 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

Interesting, this ran fine for 9 events, and only broke for the 10th event. @cvuosalo have you seen anything like this while locally testing these tags? Did I miss something in the autoCondModifier?

@srimanob
Copy link
Contributor

srimanob commented Oct 3, 2021

@cmsbuild please test

Give it another try. If we somehow have a random issue, we will see it also in the production test of dd4hep.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19346/summary.html
COMMIT: da7a5c0
CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19346/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 03-Oct-2021 05:50:47 CEST-----------------------
An exception of category 'TrackingTools/PatternTools' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 9 stream: 0
   [1] Running path 'HLT_TrkMu6NoFiltersNoVtx_v1'
   [2] Calling method for module CkfTrackCandidateMaker/'hltIterL3OITrackCandidatesNoVtx'
Exception Message:
Trajectory::check() - information requested from empty Trajectory 
----- End Fatal Exception -------------------------------------------------

@mmusich
Copy link
Contributor

mmusich commented Oct 3, 2021

@tvami @srimanob looks like you need to test with #35493

@srimanob
Copy link
Contributor

srimanob commented Oct 3, 2021

@cmsbuild please test with #35493

@qliphy
Copy link
Contributor

qliphy commented Oct 3, 2021

urgent
for 12_1_0_pre4,
see https://its.cern.ch/jira/browse/PDMVRELVALS-134

@cmsbuild cmsbuild added the urgent label Oct 3, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aefadd/19347/summary.html
COMMIT: da7a5c0
CMSSW: CMSSW_12_1_X_2021-10-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35514/19347/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-aefadd/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3085 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 6702
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3212670
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: found differences in 1 / 39 workflows

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

Results are as expected:

  • changes only in 11634.912 and there we see changes everywhere which is expected due to the geometry change

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 3, 2021

+1

@cmsbuild cmsbuild merged commit c6304f6 into cms-sw:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants