Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add invariant mass filter for generic objects in LHE events (backport) #35939

Closed

Conversation

JanFSchulte
Copy link
Contributor

This adds a LHE event filter that can cut on the invariant mass of particles of a specific type. Needed to produced high mass tail samples with Powheg for Snowmass.

This is a backport of #35938 to the release used for Snowmass sample production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2021

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_11_0_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@JanFSchulte JanFSchulte changed the title add invariant mass filter for generic objects in LHE events Add invariant mass filter for generic objects in LHE events (backport) Nov 1, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2021

Pull request #35939 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

@perrotta
Copy link
Contributor

perrotta commented Nov 2, 2021

@JanFSchulte CMSSW_11_0_X is closed since a while already. Can you please confirm that the release intended for the productions for Snowmass is really 11_0_X, and that there was no mistake in it?

And at that point, what's the plan? Do you need that such an old release get resurrected and a patch is built with this PR of yours? Or is it enough to have it coded here, and you'll apply it without the need of an actual (patch) release?

Please add some detail/explanation here (possibly in the PR description)

@JanFSchulte
Copy link
Contributor Author

JanFSchulte commented Nov 2, 2021

@perrotta maybe @Saptaparna can confirm this again, but according to her 11_0_X is the release used and for which this backport is needed. If an new release is needed or if this PR can be applied on the fly during production is also something the GEN conveners would need to comment on.

@Saptaparna
Copy link
Contributor

Yes, we would like this to be back ported to 11X so Snowmass samples can be submitted.

@qliphy
Copy link
Contributor

qliphy commented Nov 3, 2021

@Saptaparna Is there any campaign using 11_0_X? Or is it just private production? If it is mainly for Delphes, can one use master 12_X then?

@agrohsje
Copy link

agrohsje commented Nov 3, 2021

hi @qliphy. there are 2 dedicated snowmass campaigns:
https://cms-pdmv.cern.ch/mcm/campaigns?cmssw_release=CMSSW_11_0*&page=0&shown=63
using 11_0.

@qliphy
Copy link
Contributor

qliphy commented Nov 5, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ece40/20267/summary.html
COMMIT: 4452070
CMSSW: CMSSW_11_0_X_2021-11-04-1100/slc7_amd64_gcc820
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35939/20267/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793497
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 30 edm output root files, 34 DQM output files
  • TriggerResults: no differences found

@SiewYan
Copy link
Contributor

SiewYan commented Nov 8, 2021

@JanFSchulte, could you propagate the changes from 91fb6d9, we will sign it once its done. thank you!

@qliphy
Copy link
Contributor

qliphy commented Nov 15, 2021

ping @JanFSchulte

@perrotta
Copy link
Contributor

@JanFSchulte could you please take the required action: the release is waiting for this PR to be merged

@SiewYan please let us know if this PR is really deemed necessary for the new 11_X release: if not, we can cut it now, and remove this PR from the 11_X queue (since we don't plan further 11_X release after the forthcoming one)

@agrohsje
Copy link

Hi @perrotta , both PR's (this and the one that just pinged us) are for snowmass and the snowmass production campaign. :-(

@SiewYan
Copy link
Contributor

SiewYan commented Nov 22, 2021

Gentle reminder @JanFSchulte

@JanFSchulte
Copy link
Contributor Author

Based on feedback we got from UPSG, it looks like we can do our snowmass extrapolations without the samples this filter would have been needed for. I'll close this PR.

@agrohsje
Copy link

Hi @qliphy @perrotta , as this PR is no needed anymore for UPSG, please proceed with building the new release for 11_0. Thanks so much.

@qliphy
Copy link
Contributor

qliphy commented Nov 22, 2021

Hi @qliphy @perrotta , as this PR is no needed anymore for UPSG, please proceed with building the new release for 11_0. Thanks so much.

@agrohsje 11_0_4 is now being built: #36205

@agrohsje
Copy link

Thanks so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants