Add invariant mass filter for generic objects in LHE events #35938
Conversation
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35938/26339
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35938/26340
|
|
A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| double Mass = std::sqrt(E * E - (Px * Px + Py * Py + Pz * Pz)); | ||
|
|
||
| // event accept/reject logic | ||
| if (Mass > minMass_ && Mass < maxMass_ && nFound == numRequired_) { |
There was a problem hiding this comment.
do not understand which Mass is supposed to be selected if more than one particle is found.
maybe the mass cut should be applied to {++nFound;}.
btw a m^2 cut will avoid a sqrt...
There was a problem hiding this comment.
This filter was developed to cut on the invariant mass of two leptons, which are counted with nFound, so numRequired would be 2 for the cut to be applied in that case.
There was a problem hiding this comment.
still the mass is the one of the second (pretty random)
There was a problem hiding this comment.
no - its of how ever many particles pass the requirement on line 72 and are found in the particleID list
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-345cce/20174/summary.html CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-345cce/20174/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
| double Mass = std::sqrt(E * E - (Px * Px + Py * Py + Pz * Pz)); | ||
|
|
||
| // event accept/reject logic | ||
| if (Mass > minMass_ && Mass < maxMass_ && nFound == numRequired_) { |
There was a problem hiding this comment.
| double Mass = std::sqrt(E * E - (Px * Px + Py * Py + Pz * Pz)); | |
| // event accept/reject logic | |
| if (Mass > minMass_ && Mass < maxMass_ && nFound == numRequired_) { | |
| if (nFound == numRequired_) { | |
| double Mass = std::sqrt(E * E - (Px * Px + Py * Py + Pz * Pz)); | |
| // event accept/reject logic | |
| if (Mass > minMass_ && Mass < maxMass) { | |
| passedEvents_++; | |
| return true; | |
| } | |
| } | |
| return false; |
|
|
||
| // ----------member data --------------------------- | ||
|
|
||
| edm::EDGetTokenT<LHEEventProduct> src_; |
There was a problem hiding this comment.
All class members can be made const, and the filter become a global one
There was a problem hiding this comment.
Actually, the counters prevented this change because they get incremented in the filter method. But since they are not necessary to have, I have removed them.
cmsbuild
added
code-checks-pending
and removed
tests-approved
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35938/26380
|
|
Pull request #35938 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-345cce/20214/summary.html Comparison SummarySummary:
|
|
ping @cms-sw/generators-l2 |
|
@SiewYan do you see any problems here? Can this PR be merged? |
|
@Saptaparna , it looks good to me. I suggest we may merge this PR. |
|
+1 |
cmsbuild
added
fully-signed
generators-approved
and removed
generators-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
This adds a LHE event filter that can cut on the invariant mass of particles of a specific type. Needed to produced high mass tail samples with Powheg for Snowmass.