Backport of LHEGenericMassFilter to 106X #36754

JanFSchulte · 2022-01-19T17:48:42Z

This PR backports the LHE filter designed to cut on the invariant mass of a number of particles introduced in #35938. Backport to 10_6_X is necessary since some high dilepton mass ttbar and WW samples need to be produced in the UL campaigns.

cmsbuild · 2022-01-19T17:49:08Z

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for CMSSW_10_6_X.

It involves the following packages:

GeneratorInterface/GenFilters (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2022-01-19T17:56:15Z

Pull request #36754 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

agrohsje · 2022-01-19T18:21:39Z

Hi @qliphy @perrotta , I removed myself from the l2-generators team but I still get mails about PR's. Does it take a while to update or should I remove my name somewhere else?

agrohsje · 2022-01-19T18:22:14Z

please test

perrotta · 2022-01-19T18:30:31Z

@agrohsje I still see your nick listed for "generators" in https://github.com/cms-sw/cms-bot/blob/master/categories.py

The following bot PR removes it:
cms-sw/cms-bot#1692
If it is actually what you wan't, please confirm and we'll merge it.

JanFSchulte · 2022-01-21T14:09:18Z

I am not sure what the issue is here. In the tests I see only workflow 4.76 failing, which I can not check locally since the input files are not found at T2_CH_CERN. The code introduced here is not used in any of the tests, so I can't see how a failure would be related.

perrotta · 2022-01-21T14:13:05Z

I am not sure what the issue is here. In the tests I see only workflow 4.76 failing, which I can not check locally since the input files are not found at T2_CH_CERN. The code introduced here is not used in any of the tests, so I can't see how a failure would be related.

@JanFSchulte the crash in wf 4.76 is unrelated (see #36771). Please disregard that workflow for now

SiewYan · 2022-01-24T05:41:34Z

@perrotta , should i re-trigger the test and avoid 4.76 to complete the test?

JanFSchulte · 2022-01-27T18:16:40Z

Could someone comment on the status of this PR? We would like to have if merged so we know we can move ahead with preparing the sample requests.

perrotta · 2022-01-27T18:52:38Z

GeneratorInterface/GenFilters/interface/LHEGenericMassFilter.h

+class LHEGenericMassFilter : public edm::global::EDFilter<> {
+public:
+  explicit LHEGenericMassFilter(const edm::ParameterSet&);
+  ~LHEGenericMassFilter() override;


Suggested change

~LHEGenericMassFilter() override;

~LHEGenericMassFilter() override = default;

perrotta · 2022-01-27T18:52:57Z

GeneratorInterface/GenFilters/src/LHEGenericMassFilter.cc

+LHEGenericMassFilter::~LHEGenericMassFilter() {
+  // do anything here that needs to be done at destruction time
+  // (e.g. close files, deallocate resources etc.)
+}


Suggested change

LHEGenericMassFilter::~LHEGenericMassFilter() {

// do anything here that needs to be done at destruction time

// (e.g. close files, deallocate resources etc.)

}

perrotta · 2022-01-27T18:53:44Z

GeneratorInterface/GenFilters/interface/LHEGenericMassFilter.h

+
+private:
+  bool filter(edm::StreamID, edm::Event&, edm::EventSetup const&) const override;
+  void endJob() override;


Probably not needed

perrotta · 2022-01-27T18:56:02Z

GeneratorInterface/GenFilters/src/LHEGenericMassFilter.cc

+    double Mass = std::sqrt(E * E - (Px * Px + Py * Py + Pz * Pz));
+    if (Mass > minMass_ && Mass < maxMass_) {


Suggested change

double Mass = std::sqrt(E * E - (Px * Px + Py * Py + Pz * Pz));

if (Mass > minMass_ && Mass < maxMass_) {

double sqrdMass = (E * E - (Px * Px + Py * Py + Pz * Pz);

if (sqrdMass > minMass_*minMass_ && Mass < maxMass_*maxMass_) {

perrotta · 2022-01-27T18:58:35Z

As in the backported PR, I would move it into the \plugin area, also combining the header and implementation file into a single .cc
By the way, why didn't you backport it as it was?

cmsbuild · 2022-01-27T20:36:43Z

Pull request #36754 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please check and sign again.

JanFSchulte · 2022-01-27T20:38:52Z

I have merged the files and moved them to plugins. I had split them up to conform to the structure of the other modules in this package, and because I had issues getting it to be included in the compilation when it was in the plugins folder. I realized now that was because there was no BuildFile.xml there, so now everything works.

cmsbuild · 2022-01-27T20:40:43Z

Pull request #36754 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please check and sign again.

SiewYan · 2022-01-28T06:10:05Z

please test

cmsbuild · 2022-01-28T09:20:05Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25e45e/22055/summary.html
COMMIT: cc76571
CMSSW: CMSSW_10_6_X_2022-01-26-1100/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36754/22055/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 3215686
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3215350
DQMHistoTests: Total skipped: 334
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 143 log files, 29 edm output root files, 35 DQM output files
TriggerResults: no differences found

SiewYan · 2022-01-30T13:07:11Z

+1

its look good to me.

cmsbuild · 2022-01-30T13:07:32Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-01-30T13:52:02Z

+1

backport of LHEGenericMassFilter to 106X

cb09ae1

cmsbuild added this to the CMSSW_10_6_X milestone Jan 19, 2022

cmsbuild added generators-pending orp-pending pending-signatures tests-pending labels Jan 19, 2022

code format and code checks

c8bceef

cmsbuild added tests-started and removed tests-pending labels Jan 19, 2022

cmsbuild added tests-pending and removed tests-started labels Jan 19, 2022

perrotta reviewed Jan 27, 2022

View reviewed changes

merge files and move to plugins - also add BuildFile

dd6c920

code checks and format

cc76571

cmsbuild added tests-started and removed tests-pending labels Jan 28, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 28, 2022

cmsbuild added fully-signed generators-approved and removed generators-pending pending-signatures labels Jan 30, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 30, 2022

cmsbuild merged commit 5dfb2c0 into cms-sw:CMSSW_10_6_X Jan 30, 2022

perrotta mentioned this pull request Jan 30, 2022

Synchronize LHEGenericMassFilter with the latest updates merged in 10_6 #36838

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport of LHEGenericMassFilter to 106X #36754

Backport of LHEGenericMassFilter to 106X #36754

JanFSchulte commented Jan 19, 2022

cmsbuild commented Jan 19, 2022

cmsbuild commented Jan 19, 2022

agrohsje commented Jan 19, 2022

agrohsje commented Jan 19, 2022

perrotta commented Jan 19, 2022

JanFSchulte commented Jan 21, 2022

perrotta commented Jan 21, 2022

SiewYan commented Jan 24, 2022

JanFSchulte commented Jan 27, 2022

perrotta Jan 27, 2022

JanFSchulte Jan 27, 2022

perrotta Jan 27, 2022

JanFSchulte Jan 27, 2022

perrotta Jan 27, 2022

JanFSchulte Jan 27, 2022

perrotta Jan 27, 2022

JanFSchulte Jan 27, 2022

perrotta commented Jan 27, 2022

cmsbuild commented Jan 27, 2022

JanFSchulte commented Jan 27, 2022

cmsbuild commented Jan 27, 2022

SiewYan commented Jan 28, 2022

cmsbuild commented Jan 28, 2022

SiewYan commented Jan 30, 2022

cmsbuild commented Jan 30, 2022

qliphy commented Jan 30, 2022

	~LHEGenericMassFilter() override;
	~LHEGenericMassFilter() override = default;

		double Mass = std::sqrt(E * E - (Px * Px + Py * Py + Pz * Pz));
		if (Mass > minMass_ && Mass < maxMass_) {

Backport of LHEGenericMassFilter to 106X #36754

Backport of LHEGenericMassFilter to 106X #36754

Conversation

JanFSchulte commented Jan 19, 2022

cmsbuild commented Jan 19, 2022

cmsbuild commented Jan 19, 2022

agrohsje commented Jan 19, 2022

agrohsje commented Jan 19, 2022

perrotta commented Jan 19, 2022

JanFSchulte commented Jan 21, 2022

perrotta commented Jan 21, 2022

SiewYan commented Jan 24, 2022

JanFSchulte commented Jan 27, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

perrotta commented Jan 27, 2022

cmsbuild commented Jan 27, 2022

JanFSchulte commented Jan 27, 2022

cmsbuild commented Jan 27, 2022

SiewYan commented Jan 28, 2022

cmsbuild commented Jan 28, 2022

Comparison Summary

SiewYan commented Jan 30, 2022

cmsbuild commented Jan 30, 2022

qliphy commented Jan 30, 2022