MillePedeAlignmentAlgorithm: update for new GBL version

[iarspider]

PR description:

Update MillePedeAlignmentAlgorithm to cope with API changes in GBL (see cms-sw/cmsdist#7638).

PR validation:

Tested in CMSDIST PR

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37008/28432

ERROR: Build errors found during clang-tidy run.

Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc:517:24: error: no member named 'numMeasurements' in 'gbl::GblPoint'; did you mean 'hasMeasurement'? [clang-diagnostic-error]
          if (itPoint->numMeasurements() >= 1)
                       ^~~~~~~~~~~~~~~
                       hasMeasurement
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[smuzaffar]

code-checks with cms.week1.PR_63647d92/52.0-f31bcba2421d66544c8f93406ffdb32c

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37008/28434

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Alignment/MillePedeAlignmentAlgorithm (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

test parameters:

• addpkg = Alignment/TrackerAlignment

[tvami]

@cmsbuild , please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77944d/22546/summary.html
COMMIT: ba97b6f
CMSSW: CMSSW_12_3_X_2022-02-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37008/22546/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @fabiocos MTD reconstruction: speed up TrackExtenderWithMTD #36793
• @trackreco mkFit external integration #36546

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77944d/22546/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77944d/22546/git-merge-result

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MomentumDependentPedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/PedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/RunRangeDependentPedeLabeler.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/ZMuMuMassConstraintParameterFinder.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc: In member function 'std::pair MillePedeAlignmentAlgorithm::addReferenceTrajectory(const edm::EventSetup&, const AlignmentAlgorithmBase::EventInfo&, const value_type&)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc:517:24: error: 'class gbl::GblPoint' has no member named 'numMeasurements'; did you mean 'addMeasurement'?
  517 |           if (itPoint->numMeasurements() >= 1)
      |                        ^~~~~~~~~~~~~~~
      |                        addMeasurement
gmake: *** [tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/MillePedeAlignmentAlgorithm.cc.o] Error 1
>> Building  edm plugin tmp/slc7_amd64_gcc10/src/Alignment/MillePedeAlignmentAlgorithm/plugins/AlignmentMillePedeAlignmentAlgorithmAuto/libAlignmentMillePedeAlignmentAlgorithmAuto.so


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

>> Entering Package RecoTracker/FinalTrackSelectors
>> Entering Package RecoTracker/MkFit
>> Entering Package RecoTracker/MkFitCMS
>> Entering Package RecoTracker/MkFitCore
>> Compile sequence completed for CMSSW CMSSW_12_3_X_2022-02-20-2300
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1
+ eval scram build outputlog '&&' '(python3' /data/cmsbld/jenkins/workspace/ib-run-pr-tests/cms-bot/buildLogAnalyzer.py --ignoreWarning=Wdeprecated-declarations --logDir /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/tmp/slc7_amd64_gcc10/cache/log/src '||' 'true)'
++ scram build outputlog
>> Entering Package Alignment/MillePedeAlignmentAlgorithm
Entering library rule at src/Alignment/MillePedeAlignmentAlgorithm/plugins
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_3_X_2022-02-20-2300/src/Alignment/MillePedeAlignmentAlgorithm/plugins/MillePedeAlignmentAlgorithm.cc


[mmusich]

@cmsbuild please test with cms-sw/cmsdist#7638

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77944d/22571/summary.html
COMMIT: ba97b6f
CMSSW: CMSSW_12_3_X_2022-02-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37008/22571/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @jeongeun Clean up redundant edm ParameterSet existAs or exist in RecoTracker/{TkSeedGenerator} #36989
• @alejands Create new ECAL DQM GpuTask to monitor and compare CPU and GPU generated ECAL RECO objects #36742

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77944d/22571/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77944d/22571/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3965143
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3965113
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• we need Update GBL (and move to git instead of svn) cmsdist#7638 to go in first

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1