Remove unused variable use_preshower from PFECALSuperClusterProducer #37756
Conversation
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37756/29627
|
|
A new Pull Request was created by @swagata87 (Swagata Mukherjee) for master. It involves the following packages:
@Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@swagata87, thanks for the cleanup. We also need to add a customisation for the Phase-1 HLT menus, e.g. diff --git a/HLTrigger/Configuration/python/customizeHLTforCMSSW.py b/HLTrigger/Configuration/python/customizeHLTforCMSSW.py
index 23820895fc2..72e70bc3651 100644
--- a/HLTrigger/Configuration/python/customizeHLTforCMSSW.py
+++ b/HLTrigger/Configuration/python/customizeHLTforCMSSW.py
@@ -172,6 +172,16 @@ def customiseFor37231(process):
return process
+def customiseFor37756(process):
+ """https://github.com/cms-sw/cmssw/pull/37756
+ Removal of use_preshower parameter from PFECALSuperClusterProducer
+ """
+ for prod in producers_by_type(process, 'PFECALSuperClusterProducer'):
+ if hasattr(prod, 'use_preshower'):
+ delattr(prod, 'use_preshower')
+
+ return process
+
def customiseForOffline(process):
# https://its.cern.ch/jira/browse/CMSHLT-2271
@@ -192,5 +202,6 @@ def customizeHLTforCMSSW(process, menuType="GRun"):
# process = customiseFor12718(process)
process = customiseFor37231(process)
+ process = customiseFor37756(process)
return process |
|
thanks Marino. I will include it soon. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37756/29649
|
|
Pull request #37756 was updated. @Martin-Grunewald, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata can you please check and sign again. |
|
please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-899626/24386/summary.html Comparison SummarySummary:
|
|
+hlt |
Unfortunately, we now have a merge-conflict, as expected after the integration of #37646. @swagata87 , this PR should be rebased on |
|
Thanks Marino, I rebased on |
|
please test |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37756/29706
|
|
Pull request #37756 was updated. @jpata, @missirol, @Martin-Grunewald, @clacaputo, @slava77 can you please check and sign again. |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-899626/24440/summary.html Comparison SummarySummary:
|
|
+hlt |
|
+reconstruction |
cmsbuild
added
fully-signed
reconstruction-approved
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
The variable
use_preshowerinPFECALSuperClusterProducer.ccis not used anywhere, but just creates confusion. It seems like setting it to true/false would lead to using/not using preshower energy for superclustering; while that is not the case. This variable has no effect anywhere and should just be removed to avoid further confusion.This PR is just meant for code cleanup. No change in physics is expected.
PR validation:
cmsDriver.py --filein /store/relval/CMSSW_12_4_0_pre3/RelValZpToEE_m6000_14TeV/GEN-SIM-DIGI-RAW/123X_mcRun3_2021_realistic_v14-v1/2580000/42d345d9-79a2-4006-8d6b-b4241a553f42.root --fileout file:AOD.root --mc --eventcontent AODSIM --runUnscheduled --customise Configuration/DataProcessing/Utils.addMonitoring --datatier AODSIM --conditions 123X_mcRun3_2021_realistic_v14 --step RAW2DIGI,RECO --geometry DB:Extended --era Run3 --python_filename aod_cfg.py --beamspot Run3RoundOptics25ns13TeVLowSigmaZ --no_exec -n 200then
cmsRun aod_cfg.pyIt ran fine.
This PR is not a backport.
Backport not necessary.