Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMSSW_12_3_X] Make AlCaPhiSymEcal_Nano inherit from pp instead of AlCa #37800

Merged
merged 1 commit into from
May 5, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented May 4, 2022

PR description:

See #37784

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37784

@tvami
Copy link
Contributor Author

tvami commented May 4, 2022

assign alca

@tvami
Copy link
Contributor Author

tvami commented May 4, 2022

type ecal

@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone May 4, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

@tvami
Copy link
Contributor Author

tvami commented May 4, 2022

backport of #37784

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/DataProcessing (operations)

@perrotta, @malbouis, @yuanchao, @tvami, @cmsbuild, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami tvami changed the title Make AlCaPhiSymEcal_Nano inherit from pp instead of AlCa [CMSSW_12_3_X] Make AlCaPhiSymEcal_Nano inherit from pp instead of AlCa May 4, 2022
@tvami
Copy link
Contributor Author

tvami commented May 4, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 4, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-942d69/24446/summary.html
COMMIT: 92f0a11
CMSSW: CMSSW_12_3_X_2022-05-04-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37800/24446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696087
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3696057
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented May 4, 2022

+alca

@perrotta
Copy link
Contributor

perrotta commented May 5, 2022

+1

  • This PR does not affect standard workflows.
  • It needs to be tested at T0, so let merge it to get included in the next 12_3 patch release

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c17c3d0 into cms-sw:CMSSW_12_3_X May 5, 2022
@perrotta
Copy link
Contributor

perrotta commented May 5, 2022

@tvami CMSSW_12_3_2_patch1 is now available, see https://github.com/cms-sw/cmssw/releases/CMSSW_12_3_2_patch1

@tvami
Copy link
Contributor Author

tvami commented May 5, 2022

Hi @perrotta thanks! We already launched a replay with it 1.5 hours ago
dmwm/T0#4664 (comment)
(I was sneaking in the github issue that created the patch release :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants