-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecoTracker/MkfitCore: Add fast-math and function attribute need to prevent segfault #38147
RecoTracker/MkfitCore: Add fast-math and function attribute need to prevent segfault #38147
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38147/30290
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
enable profiling |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38147/30296
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
7251b85
to
19b46ed
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38147/30297
|
Pull request #38147 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77cf4a/25125/summary.html Comparison SummarySummary:
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-77cf4a/25291/summary.html Comparison SummarySummary:
|
type tracking |
assign tracking-pog The reco differences introduced by this PR seems minimal to me, but I'd like to have a crosscheck by tracking-pog |
Looking at the profile, the mkFit related calls got down from 15.26 ticks to 13.81. So, this is about 10% reduction. |
thanks for reporting, I fixed it now in the original message |
this PR is not purely technical and differences in physics are visually larger than what you'd usually see with small shuffle at the numerical precision level. e.g. the number of tracks in detached triplet and pixelLess iterations went down a bit, as can be seen in DQM bin-to-bin for wf 136.874 https://tinyurl.com/2d3gpg9c So, it may make more sense to have this formally validated first and then backported. |
this is the validation on 10 muon sample (pT 0.2 to 1000) ttbar with PU sample red only adds the PR 38147 to the code wrt to blue. |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
Add fast-math flag and attribute needed to prevent segfault when fast-math is used
This PR adds back the options which enable the vectorized function from libmvec on EL8. This causes a differences in RECO DQM.
Followup PR to #37868