Replace Geometry_cff with GeometryDB_cff in RecoEgamma #38285

jeongeun · 2022-06-08T11:33:58Z

PR description:
Review on the Reco part of #31113

process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")

In this PR, RecoEgamma configuration files (10 files) are fixed.

modified:   RecoEgamma/EgammaElectronProducers/test/egammaClustersToGsfElectrons_cfg.py
modified:   RecoEgamma/EgammaElectronProducers/test/egammaCoresToGsfElectrons_cfg.py
modified:   RecoEgamma/EgammaElectronProducers/test/egammaRawDataToGsfElectrons_cfg.py
modified:   RecoEgamma/EgammaElectronProducers/test/egammaRecHitsToElectronSeeds_cfg.py
modified:   RecoEgamma/EgammaElectronProducers/test/egammaRecHitsToGsfElectrons_cfg.py
modified:   RecoEgamma/EgammaIsolationAlgos/test/egammaIsoTest_cfg.py
modified:   RecoEgamma/EgammaIsolationAlgos/test/pfclusterIsoTest_cfg.py
modified:   RecoEgamma/EgammaIsolationAlgos/test/runInterestingEgammaIsoDetIdsSequence_cfg.py
modified:   RecoEgamma/ElectronIdentification/test/eidSelectorTest_cfg.py
modified:   RecoEgamma/ElectronIdentification/test/runElectronID_cfg.py

From 12_4_X to 12_5_X, following 4 files in Examples/test/ are all removed.
RecoEgamma/Examples/test/ElectronSeedMCAnalyzer_cfg.py
RecoEgamma/Examples/test/GsfElectronRedoFromCore_cfg.py
RecoEgamma/Examples/test/GsfElectronRedoFromRaw_cfg.py
RecoEgamma/Examples/test/SimplePi0DiscAnalyzer_cfg.py

cmsbuild · 2022-06-08T11:39:09Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38285/30438

ERROR: Unable to merge PR.

See log https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38285/30438/cms-checkout-topic.log

cmsbuild · 2022-06-08T11:53:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38285/30440

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoEgamma/Examples/test/ElectronSeedMCAnalyzer_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429
- File RecoEgamma/Examples/test/GsfElectronRedoFromCore_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429
- File RecoEgamma/Examples/test/GsfElectronRedoFromRaw_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429
- File RecoEgamma/Examples/test/SimplePi0DiscAnalyzer_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429

cmsbuild · 2022-06-08T11:54:09Z

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoEgamma/EgammaElectronProducers (reconstruction)
RecoEgamma/EgammaIsolationAlgos (reconstruction)
RecoEgamma/ElectronIdentification (reconstruction)
RecoEgamma/Examples (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @valsdav, @rovere, @lgray, @sobhatta, @lecriste, @afiqaize, @wrtabb, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

jpata · 2022-06-08T12:35:21Z

@cmsbuild please test

cmsbuild · 2022-06-08T17:42:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50eeb2/25357/summary.html
COMMIT: e89a5e4
CMSSW: CMSSW_12_5_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38285/25357/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3652078
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3652048
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

clacaputo · 2022-06-10T10:57:30Z

RecoEgamma/ElectronIdentification/test/eidSelectorTest_cfg.py

@@ -4,7 +4,7 @@

 process.load('FWCore/MessageService/MessageLogger_cfi')


Could you please also change

Suggested change

process.load('FWCore/MessageService/MessageLogger_cfi')

process.load('FWCore.MessageService.MessageLogger_cfi')

clacaputo · 2022-06-10T10:57:44Z

RecoEgamma/ElectronIdentification/test/eidSelectorTest_cfg.py

@@ -4,7 +4,7 @@

 process.load('FWCore/MessageService/MessageLogger_cfi')
 process.load('Configuration/StandardSequences/Services_cff')


Suggested change

process.load('Configuration/StandardSequences/Services_cff')

process.load('Configuration.StandardSequences.Services_cff')

clacaputo · 2022-06-10T10:58:01Z

RecoEgamma/ElectronIdentification/test/runElectronID_cfg.py

@@ -4,7 +4,7 @@

 process.load('FWCore/MessageService/MessageLogger_cfi')


Suggested change

process.load('FWCore/MessageService/MessageLogger_cfi')

process.load('FWCore.MessageService.MessageLogger_cfi')

clacaputo · 2022-06-10T10:58:25Z

RecoEgamma/ElectronIdentification/test/runElectronID_cfg.py

@@ -4,7 +4,7 @@

 process.load('FWCore/MessageService/MessageLogger_cfi')
 process.load('Configuration/StandardSequences/Services_cff')


Suggested change

process.load('Configuration/StandardSequences/Services_cff')

process.load('Configuration.StandardSequences.Services_cff')

cmsbuild · 2022-06-14T15:25:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38285/30563

This PR adds an extra 16KB to repository

cmsbuild · 2022-06-14T15:25:51Z

Pull request #38285 was updated. @jpata, @cmsbuild, @clacaputo, @slava77 can you please check and sign again.

clacaputo · 2022-06-15T08:18:45Z

@cmsbuild please test

cmsbuild · 2022-06-15T12:16:36Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50eeb2/25534/summary.html
COMMIT: 99ed83e
CMSSW: CMSSW_12_5_X_2022-06-14-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38285/25534/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 50
DQMHistoTests: Total histograms compared: 3659074
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3659044
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
Checked 208 log files, 45 edm output root files, 50 DQM output files
TriggerResults: no differences found

clacaputo · 2022-06-15T13:34:16Z

+reconstruction

technical PR
no reco changes

cmsbuild · 2022-06-15T13:34:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-06-15T13:46:13Z

+1

tvami · 2022-06-16T00:34:40Z

Let me comment that when the GeometryDB is used (as the name says) the geometry is taken from the DB, meaning that a GT will have to be specified. I see some of the modified files dont have that, for example
https://github.com/jeongeun/cmssw/blob/99ed83e1c8d3ee0474b5d347ea519ea34e22a1b2/RecoEgamma/EgammaIsolationAlgos/test/egammaIsoTest_cfg.py
so that's not expected to work after this migration. Some other files have very old GTs, which might work or not.

Given that fact that no wf has been broken that means these files are actually not used anywhere... but when/if they will be used, they'll need to have a GT in them

replace Geometry_cff with GeometryDB_cff in RecoEgamma

ce57615

cmsbuild added this to the CMSSW_12_5_X milestone Jun 8, 2022

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 8, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jun 8, 2022

remove Examples

e89a5e4

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 8, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 8, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 8, 2022

clacaputo suggested changes Jun 10, 2022

View reviewed changes

minor fix

f6c02d1

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Jun 14, 2022

minor fix 2

09c36bb

minor fix 3

99ed83e

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 14, 2022

cmsbuild added tests-started and removed tests-pending labels Jun 15, 2022

cmsbuild added tests-approved and removed tests-started labels Jun 15, 2022

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Jun 15, 2022

cmsbuild added orp-approved and removed orp-pending labels Jun 15, 2022

cmsbuild merged commit 4264427 into cms-sw:master Jun 15, 2022

cmsbuild mentioned this pull request Jun 15, 2022

[DEVEL] Added alpaka build rules cms-sw/cmsdist#7936

Merged

jpata mentioned this pull request Jun 21, 2022

Replace Geometry_cff with GeometryDB_cff in RecoMuon #38374

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Geometry_cff with GeometryDB_cff in RecoEgamma #38285

Replace Geometry_cff with GeometryDB_cff in RecoEgamma #38285

jeongeun commented Jun 8, 2022 •

edited

cmsbuild commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

jpata commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

clacaputo Jun 10, 2022

clacaputo Jun 10, 2022

clacaputo Jun 10, 2022

clacaputo Jun 10, 2022

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

perrotta commented Jun 15, 2022

tvami commented Jun 16, 2022

		@@ -4,7 +4,7 @@

		process.load('FWCore/MessageService/MessageLogger_cfi')

	process.load('FWCore/MessageService/MessageLogger_cfi')
	process.load('FWCore.MessageService.MessageLogger_cfi')

		@@ -4,7 +4,7 @@

		process.load('FWCore/MessageService/MessageLogger_cfi')
		process.load('Configuration/StandardSequences/Services_cff')

	process.load('Configuration/StandardSequences/Services_cff')
	process.load('Configuration.StandardSequences.Services_cff')

Replace Geometry_cff with GeometryDB_cff in RecoEgamma #38285

Replace Geometry_cff with GeometryDB_cff in RecoEgamma #38285

Conversation

jeongeun commented Jun 8, 2022 • edited

cmsbuild commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

jpata commented Jun 8, 2022

cmsbuild commented Jun 8, 2022

Comparison Summary

clacaputo Jun 10, 2022

Choose a reason for hiding this comment

clacaputo Jun 10, 2022

Choose a reason for hiding this comment

clacaputo Jun 10, 2022

Choose a reason for hiding this comment

clacaputo Jun 10, 2022

Choose a reason for hiding this comment

cmsbuild commented Jun 14, 2022

cmsbuild commented Jun 14, 2022

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

Comparison Summary

clacaputo commented Jun 15, 2022

cmsbuild commented Jun 15, 2022

perrotta commented Jun 15, 2022

tvami commented Jun 16, 2022

jeongeun commented Jun 8, 2022 •

edited