Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Geometry_cff with GeometryDB_cff in RecoMuon #38374

Merged
merged 1 commit into from Jun 21, 2022

Conversation

jeongeun
Copy link
Contributor

PR description:
Review on the Reco part of #31113

process.load("Configuration.StandardSequences.Geometry_cff")
was outdated #8810
It should be replaced with
process.load("Configuration.StandardSequences.GeometryDB_cff")

In this PR, RecoMuon configuration files (8 files) are fixed.

RecoMuon/Configuration/test/RecoMuon_cfg.py
RecoMuon/MuonIdentification/test/TestMuonIdProducerCosmics_cfg.py
RecoMuon/MuonIdentification/test/TestMuonIdProducer_cfg.py
RecoMuon/MuonIsolationProducers/test/isoTest_cfg.py
RecoMuon/MuonSeedGenerator/test/MuonSeedPTAnalysis/estimatePt_cfg.py
RecoMuon/MuonSeedGenerator/test/testMuonSeedMerger_cfg.py
RecoMuon/MuonSeedGenerator/test/testSETMuonSeed_cfg.py
RecoMuon/StandAloneMuonProducer/test/StandAloneMuon_cfg.py

PR validation:

Tested in CMSSW_12_5_X, the basic test all passed in the CMSSW PR instructions

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38374/30567

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

  • RecoMuon/Configuration (reconstruction)
  • RecoMuon/MuonIdentification (reconstruction)
  • RecoMuon/MuonIsolationProducers (reconstruction)
  • RecoMuon/MuonSeedGenerator (reconstruction)
  • RecoMuon/StandAloneMuonProducer (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@HuguesBrun, @abbiendi, @Fedespring, @bellan, @sscruz, @jhgoh, @CeliaFernandez, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented Jun 16, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-759ecb/25562/summary.html
COMMIT: 91e601a
CMSSW: CMSSW_12_5_X_2022-06-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38374/25562/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659074
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3659044
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jpata
Copy link
Contributor

jpata commented Jun 21, 2022

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Technically correct, even if rather useless, as evidently all those test configs weren't used since some while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants