[12_3_X Backport] ECAL DQM GpuTask add 2D comparison histograms and enable GPU validation on online DQM

[alejands]

PR description:

The following additions are made to the ECAL DQM GPU validation module:

• Add in 2D histograms for comparing CPU and GPU generated values of ECAL digis, uncalibrated rec hits, and rec hits
• Create separate subdirectories for each ECAL object (digis, uncalibrated rec hits, rec hits) to reduce clutter with too many plots in one place
• Create more flags to be able to better customize what plots to make when running the module. Eg. for digis, enableDigi toggles running over GPU and CPU digi collections (creates CPU value 1D distribution and 1D GPU-CPU value difference by default), digi1D enables GPU value 1D distribution, and digi2D enables the 2D plots plots mentioned above
• Create separate dedicated client for GPU validation on ECAL online DQM

This PR addresses the remaining outstanding tasks in this issue: #37025

PR validation:

Online DQM configuration tested on test file provided by DQM-DC containing the new HLT collections. Offline DQM configuration tested on CPU-only and GPU WFs (runTheMatrix.py -w upgrade -l 11634.511,11634.512,11634.513).

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #38427 to use in data taking

[cmsbuild]

A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_12_3_X.

It involves the following packages:

• DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from ECAL DQM GpuTask add 2D comparison histograms and enable GPU validation on online DQM #38427

[fwyzard]

enable gpu

[fwyzard]

please test

[fwyzard]

backport #38427

[fwyzard]

type new-feature

[fwyzard]

type ecal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82f417/25628/summary.html
COMMIT: 113a6c1
CMSSW: CMSSW_12_3_X_2022-06-19-2300/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38428/25628/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• You potentially added 242 lines to the logs
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 3 failed jobs
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19864
• DQMHistoTests: Total failures: 620
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19244
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1980.436 KiB( 3 files compared)
• DQMHistoSizes: changed ( 11634.512 ): 990.218 KiB EcalBarrel/EBGpuTask
• DQMHistoSizes: changed ( 11634.512 ): 990.218 KiB EcalEndcap/EEGpuTask
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• You potentially added 40706 lines to the logs
• Reco comparison results: 82 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3630290
• DQMHistoTests: Total failures: 37
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3630231
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 73276.13200000004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 990.218 KiB EcalBarrel/EBGpuTask
• DQMHistoSizes: changed ( 1000.0,... ): 990.218 KiB EcalEndcap/EEGpuTask
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

@alejands we tested the PR at P5, the clients are running ok, the stream files are being consumed, and there is a new ECAL GPU workspace in the GUI, however it looks like this is not filled with CPU/GPU graphs as described in the PR

[alejands]

@emanueleusai What I see in my private test GUI is that the plots are still inside the Ecal workspace, located at (top)/EcalBarrel/EBGpuTask and (top)/EcalEndcap/EEGpuTask, but I also don't see a new EcalGPU workspace.

If we want to move the plots to Layouts for more visibility, we would do it here (not in CMSSW): https://github.com/dmwm/deployment/blob/master/dqmgui/layouts/ecal-layouts.py
or I imagine a similar file for a new EcalGPU workspace

[alejands]

The ecalcalib client is similar in that it also changes the stream label
https://github.com/cms-sw/cmssw/blob/master/DQM/Integration/python/clients/ecalcalib_dqm_sourceclient-live_cfg.py#L160
and the dqmSaver info
https://github.com/cms-sw/cmssw/blob/master/DQM/Integration/python/clients/ecalcalib_dqm_sourceclient-live_cfg.py#L190-L194
but the all the plots are still part of the Ecal workspace

[emanueleusai]

@alejands ok thank you for pointing that out, now I can see the comparison plots being filled correctly.
However it was this PR that created the EcalGPU empty folder in the workspace here: https://github.com/cms-sw/cmssw/pull/38428/files#diff-7e9b17ce9f9a19ae82d8a705a90d5fab2e021a4f0e18f0a84d7a9875621c4224R63

Was it intended for something in particular?
If you want to give more visibility to the comparison plots and move them to the EcalGPU I am ok with it

[alejands]

@emanueleusai No there was no particular reason. I changed the settings to match the ecalcalib client. I can change it back, but I don't if people would prefer me to do it here to in a separate PR and merge this one. I see the PR porting the last commit here to master #38527 and 12_4_X #38528 is already merged

[emanueleusai]

well if the extra folder is empty and not used for anything it should be removed. I would do it in this PR for 12_3 and then open bugfix PR for master and 12_4

[cmsbuild]

Pull request #38428 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-82f417/25954/summary.html
COMMIT: 9cb65c3
CMSSW: CMSSW_12_3_X_2022-07-03-0000/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38428/25954/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• Reco comparison had 3 failed jobs
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19864
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19856
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3626218
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3626182
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

re-tested at p5 and re-deployed

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1