Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X Backport] ECAL DQM GpuTask add 2D comparison histograms and enable GPU validation on online DQM #38429

Merged
merged 8 commits into from
Jun 27, 2022

Conversation

alejands
Copy link
Contributor

@alejands alejands commented Jun 20, 2022

PR description:

The following additions are made to the ECAL DQM GPU validation module:

  • Add in 2D histograms for comparing CPU and GPU generated values of ECAL digis, uncalibrated rec hits, and rec hits
  • Create separate subdirectories for each ECAL object (digis, uncalibrated rec hits, rec hits) to reduce clutter with too many plots in one place
  • Create more flags to be able to better customize what plots to make when running the module. Eg. for digis, enableDigi toggles running over GPU and CPU digi collections (creates CPU value 1D distribution and 1D GPU-CPU value difference by default), digi1D enables GPU value 1D distribution, and digi2D enables the 2D plots plots mentioned above
  • Create separate dedicated client for GPU validation on ECAL online DQM

This PR addresses the remaining outstanding tasks in this issue: #37025

PR validation:

Online DQM configuration tested on test file provided by DQM-DC containing the new HLT collections. Offline DQM configuration tested on CPU-only and GPU WFs (runTheMatrix.py -w upgrade -l 11634.511,11634.512,11634.513).

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #38427 to use in data taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 20, 2022

A new Pull Request was created by @alejands (Alejandro Sanchez) for CMSSW_12_4_X.

It involves the following packages:

  • DQM/EcalMonitorTasks (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@fwyzard
Copy link
Contributor

fwyzard commented Jun 20, 2022

enable gpu

@fwyzard
Copy link
Contributor

fwyzard commented Jun 20, 2022

please test

@fwyzard
Copy link
Contributor

fwyzard commented Jun 20, 2022

backport #38427

@fwyzard
Copy link
Contributor

fwyzard commented Jun 20, 2022

type new-feature

@fwyzard
Copy link
Contributor

fwyzard commented Jun 20, 2022

type ecal

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dce442/25627/summary.html
COMMIT: e278760
CMSSW: CMSSW_12_4_X_2022-06-19-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38429/25627/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • You potentially added 242 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19864
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19855
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1980.436 KiB( 3 files compared)
  • DQMHistoSizes: changed ( 11634.512 ): 990.218 KiB EcalBarrel/EBGpuTask
  • DQMHistoSizes: changed ( 11634.512 ): 990.218 KiB EcalEndcap/EEGpuTask
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • You potentially added 40662 lines to the logs
  • Reco comparison results: 82 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 42
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680295
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 73276.13200000004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): 990.218 KiB EcalBarrel/EBGpuTask
  • DQMHistoSizes: changed ( 1000.0,... ): 990.218 KiB EcalEndcap/EEGpuTask
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #38429 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #38429 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dce442/25777/summary.html
COMMIT: 42055d8
CMSSW: CMSSW_12_4_X_2022-06-24-2300/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38429/25777/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19864
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19855
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3680359
  • DQMHistoTests: Total failures: 14
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3680323
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 27, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants