Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_photon_trigger_filters_nanoAOD #39043

Merged
merged 1 commit into from Aug 15, 2022

Conversation

bartokm
Copy link
Contributor

@bartokm bartokm commented Aug 12, 2022

PR description:

Fixing the issue reported in cms-nanoAOD#592

PR validation:

scram build code-checks
scram build code-format

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39043/31531

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bartokm for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swagata87
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e29541/26785/summary.html
COMMIT: 040d3da
CMSSW: CMSSW_12_5_X_2022-08-12-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/39043/26785/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3692476
  • DQMHistoTests: Total failures: 116
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3692337
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 212 log files, 49 edm output root files, 51 DQM output files
  • TriggerResults: no differences found

@mariadalfonso
Copy link
Contributor

+xpog

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@mariadalfonso
Copy link
Contributor

@bartokm
can you backport to 12_4 ?

@qliphy
Copy link
Contributor

qliphy commented Aug 15, 2022

+1

@cmsbuild cmsbuild merged commit 7d2e3ad into cms-sw:master Aug 15, 2022
@mariadalfonso
Copy link
Contributor

@bartokm
can you backport to 12_4 ?

@bartokm ping

cmsbuild added a commit that referenced this pull request Aug 20, 2022
Backport of #39043 and #39099: fixing e+tau cross trigger and photon trigger filters in nanoAOD
@bartokm
Copy link
Contributor Author

bartokm commented Aug 23, 2022

@bartokm
can you backport to 12_4 ?

@bartokm ping

Sorry, I was on vacation. I'm catching up with things, I'll do the backport today or tomorrow.

@mariadalfonso
Copy link
Contributor

@bartokm
can you backport to 12_4 ?

@bartokm ping

Sorry, I was on vacation. I'm catching up with things, I'll do the backport today or tomorrow.

It's already done by someone else, no need to do anymore: we needed merged by today and there was another depending PR

@bartokm
Copy link
Contributor Author

bartokm commented Aug 23, 2022

@bartokm
can you backport to 12_4 ?

@bartokm ping

Sorry, I was on vacation. I'm catching up with things, I'll do the backport today or tomorrow.

It's already done by someone else, no need to do anymore: we needed merged by today and there was another depending PR

OK. Sorry for not replying earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants