Fix nanoAOD trigger bits for e+tau overlap filter

[adewit]

PR description:

Tau trigger bits for nanoAOD do not correctly store the e+tau cross trigger overlap filter, as this filter ends, e.g. in 2018, with PFTau30 rather than PFTau. In the past the filter matching string correctly had * at the end but in this update: https://github.com/cms-sw/cmssw/pull/38472/files it was removed. Adding it back here.

FYI @mbluj @lwezenbe @kandrosov @danielwinterbottom (I don't have Anne-Catherine's github handle, can someone please tag her). Since nano v10 will close very soon I think we should try to get this fix in urgently which is why I went straight for the PR.

Spotted thanks to investigation by @PascalBaertschi.

PR validation:

Observed incorrect behaviour without the * at the end, previous runs with it included produced the correct results.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39099/31633

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @adewit for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @mariadalfonso, @gouskos, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @swertz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test

[mariadalfonso]

@adewit
can you prepare a backport to 10_4 and include this commit as well
#39043

[kandrosov]

FYI @valeriadamante @vmuralee

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-899932/26907/summary.html
COMMIT: 338d9be
CMSSW: CMSSW_12_5_X_2022-08-17-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/39099/26907/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3692500
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3692470
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 212 log files, 49 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mariadalfonso]

+xpog

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1