Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LHE generic mass filter extension #39458

Closed

Conversation

AWildridge
Copy link
Contributor

PR description:

Extended the capability of the LHEGenericMassFilter to filter on the invariant masses of non-outgoing particles by adding an additional boolean argument in the constructor. The reason this extension is required is for the production of the dileptonic and semileptonic decays of toponium. A filter on the invariant mass of toponium is required and since toponium is not an outgoing particle this filter currently is incapable of properly filtering these events. See the genproductions pull request and cards here: cms-sw/genproductions#3132 (comment)

PR validation:

I ran
scram b runtests
and
runTheMatrix.py -l limited -i all --ibeos.
No new code needs to be added for unit tests, test configurations, additions or updates to the runTheMatrix test workflows as far as I am concerned.

mbluj and others added 30 commits August 1, 2022 16:33
…nd run3_nanoAOD_122, and remove not needed customization function
…l_tracks_to_the_capacity_of_the_SoA

Clamp the number of pixel tracks to the capacity of the SoA [12.4.x]
…v1p3p0_124X

Update of L1T menu in TSG GTs to `L1Menu_Collisions2022_v1_3_0-d1_xml` [`12_4_X`]
[124X backport] HCAL: Group 0 LUT edited to set LLP bits in HB only, not HE
Automatically size the Pixel FED buffer used by SiPixelRawToClusterCUDA [12.4.x]
…r_124X

[Backport 124X] [NanoAOD] Correct filter name for Run3 Isomu triggers
limit the number of seeds, same as in CkfTrackCandidateMakerBase (backport of cms-sw#38926)
Various fixes for pixel clustering on GPU [12.4.x]
…le definition instead of hardcoded value

and use GetN instead of GetA to get target nucleon number.

Implement code-format fix for G4muDarkBremsstrahlungModel

Change G4muDarkBremsstrahlungModel to use Geant4 muon mass for
muon_mass_mev as well as GeV muon mass.
…_4_X

Remove obsolete printInfo from G4muDarkBremsstrahlung
[124X backport] Keep Run2 EGamma IDs in Run3 nano(v10)
Detect and remove all duplicate pixels [12.4.x]
…_deepTau-v2p5-WPs-nano

DeepTau v2p5 in nanoAOD [12_4_X]
mmusich and others added 16 commits September 15, 2022 09:46
Using a static local variable results in invalid ids when multiple
ProcessCallGraph instances are used e.g. by different Services.
Use a ProcessCallGraph to get the highest possible module id, instead of
relaying on the modules count.
[12_4_X] ECAL DQM GpuTask move enable flag checks to avoid unused collections from being consumed
…_12_4_Sept22

[12_4_X] Modify RPC and GEM unpacker blocks in EMTF unpacker to match the new Run 3 format
…_NVProfilerService_12_4_x

Fix the `NVProfilerService` and `ProcessCallGraph` [12.4.x]
…tDQM_12_4_X

[12.4.X] supply DQM for `SiPixelCalSingleMuonTight`
HLT menu development for `12_4_X` (8/N): HLT V1.4 of 2022
…pu-vs-cpu-monitoring-124x

ECAL - Switch off online ECAL RecHit GPU vs. CPU monitoring - 12_4_X
HBHE: arrival time [ backport 12_4 ]
…on_12_4_Sept22

[12_4_X] Added protection against out-of-range BX values in EMTF unpacker blocks
… ability to filter on non-outgoing particles
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-39458/32180

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AWildridge (AJ Wildridge) for master.

It involves the following packages:

  • (externals)

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@AWildridge
Copy link
Contributor Author

It seems I may have done this incorrectly. I performed scram project CMSSW_12_4_9 as I figured this was the master branch but it looks like I picked up a lot of commits ahead of the master branch. Please let me know what version I should have used if this is incorrect to make a PR to the master branch.

@perrotta
Copy link
Contributor

@AWildridge master has moved to 12_6_X (and to 12_5_X before that...)
Please stick on the more recent IBs for it, you can see the list e.g. in https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_12_6_X
CMSSW_12_6_X_2022-09-20-1100 is a good one by now

@AWildridge
Copy link
Contributor Author

@AWildridge master has moved to 12_6_X (and to 12_5_X before that...) Please stick on the more recent IBs for it, you can see the list e.g. in https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_12_6_X CMSSW_12_6_X_2022-09-20-1100 is a good one by now

#39459 - Here's the new PR. I was unable to get 12_6_X_2022-09-20-1100. The closest available for me was 12_6_x_2022-09-19-2300.

@AWildridge AWildridge closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet