Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2 shk24 #4073

Merged
merged 3 commits into from
Jun 3, 2014
Merged

Phase2 shk24 #4073

merged 3 commits into from
Jun 3, 2014

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Jun 2, 2014

Built on top of Phase2-ft04

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 2, 2014

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Phase2 shk24

It involves the following packages:

Geometry/HGCalCommonData
Validation/HcalHits
Validation/ShashlikValidation

The following packages do not have a category, yet:

Validation/ShashlikValidation

@civanch, @ojeda, @danduggan, @ianna, @mdhildreth, @cmsbuild, @Dr15Jones, @rovere, @deguio, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jun 2, 2014

@ktf - Could you, please, approve this new package? Thanls, Yana.

+1

@ktf
Copy link
Contributor

ktf commented Jun 2, 2014

Do we really need a package with 3 files in it?

@bsunanda
Copy link
Contributor Author

bsunanda commented Jun 2, 2014

We shall be putting a few more - all the validaion code for Shashlik and
we started with SimHit and move to RecHit etc going all the way up.

On Mon, 2 Jun 2014, Giulio Eulisse wrote:

Do we really need a package with 3 files in it?


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxNzMzMT
g3MCwiZGF0YSI6eyJpZCI6MzM1OTk3NTF9fQ==--eb9b7c5f1c60734d874462933fa6a2552ef
98ec8.gif]

@ianna
Copy link
Contributor

ianna commented Jun 3, 2014

+1

...again...

@mark-grimes
Copy link

merge

Tested all of Sunanda's requests together. Notes on #4079.

cmsbuild added a commit that referenced this pull request Jun 3, 2014
@cmsbuild cmsbuild merged commit 0715781 into cms-sw:CMSSW_6_2_X_SLHC Jun 3, 2014
@mark-grimes mark-grimes mentioned this pull request Jun 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants