New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activating v7 of HF ShowerLibrary #40933
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40933/34419
|
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Well, I have the impression that v7 is not yet there (?) as Run3/Phase2 -related jobs are failing... |
-1 Failed Tests: RelVals RelVals-INPUT AddOn RelVals
Expand to see more relval errors ...RelVals-INPUT
Expand to see more relval errors ...AddOn Tests
Expand to see more addon errors ... |
Hm...m I don't see HFShowerLibrary_run3_v7.root |
Let us wait for the morning. |
v7 seems to be available in the latest IB: -rw-r--r--. 1 cvmfs cvmfs 1180292330 Mar 3 00:03 HFShowerLibrary_run3_v7.root |
@abdoulline , these SL libs are very big (over 1GB) and we can not push these to github data repo (due to 100MB size limit). So for this data package we deploy data from http://cmsrep.cern.ch/cmssw/download/data/ . SL v7 is available in CMSSW_13_1_X_2023-03-02-2300. |
please test new SL v7 is available now in IB |
I see, thanks! |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a57f93/31021/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Preparatory work done in #40703
PR validation:
Private validation shows unchanged (physics-wise) results
https://cms-docs.web.cern.ch/hcal-sw-validation/calo_scan_single_pi/13_1_X/13_1_X_run3_HFSLv7cor_vs_13_1_X_run3_SinglePi/