Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating v7 of HF ShowerLibrary #40933

Merged
merged 1 commit into from Mar 3, 2023
Merged

Conversation

abdoulline
Copy link

PR description:

Preparatory work done in #40703

PR validation:

Private validation shows unchanged (physics-wise) results
https://cms-docs.web.cern.ch/hcal-sw-validation/calo_scan_single_pi/13_1_X/13_1_X_run3_HFSLv7cor_vs_13_1_X_run3_SinglePi/

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40933/34419

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

  • Geometry/HcalSimData (geometry)

@civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild, @bsunanda can you please review it and eventually sign? Thanks.
@bsunanda, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Mar 2, 2023

please test

@abdoulline
Copy link
Author

Well, I have the impression that v7 is not yet there (?) as Run3/Phase2 -related jobs are failing...

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a57f93/31006/summary.html
COMMIT: 6cf217e
CMSSW: CMSSW_13_1_X_2023-03-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 02-Mar-2023 16:47:19 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named Pyquen_ZeemumuJets_pt10_2760GeV_cfi_GEN_SIM_PU.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file SimG4CMS/Calo/data/HFShowerLibrary_run3_v7.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(925): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(918): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1200): _insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1465): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 02-Mar-2023 16:53:05 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_14TeV_TuneCP5_cfi_GEN_SIM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file SimG4CMS/Calo/data/HFShowerLibrary_run3_v7.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/11634.0_TTbar_14TeV+2021


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(925): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(918): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1200): _insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1465): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 02-Mar-2023 16:53:12 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_14TeV_TuneCP5_cfi_GEN_SIM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file SimG4CMS/Calo/data/HFShowerLibrary_run3_v7.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/11634.7_TTbar_14TeV+2021_trackingMkFit


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(925): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(918): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1200): _insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1465): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 11834.9911834.99_TTbar_14TeV+2021PU_PMXS1S2/step2_TTbar_14TeV+2021PU_PMXS1S2.log
  • 12634.9912634.99_TTbar_14TeV+2023PU_PMXS1S2/step2_TTbar_14TeV+2023PU_PMXS1S2.log
  • 13034.9913034.99_TTbar_14TeV+2024PU_PMXS1S2/step2_TTbar_14TeV+2024PU_PMXS1S2.log
Expand to see more relval errors ...

AddOn Tests

----- Begin Fatal Exception 02-Mar-2023 16:43:27 CET-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named TTbar_13TeV_TuneCUETP8M1_cfi_GEN_SIM_DIGI_L1_DIGI2RAW.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file SimG4CMS/Calo/data/HFShowerLibrary_run3_v7.root anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31006/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(925): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Types.py(918): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1200): _insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02774/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_1_X_2023-03-02-1100/src/FWCore/ParameterSet/python/Config.py(1465): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 02-Mar-2023 16:44:09 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_GRun_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 02-Mar-2023 16:46:43 CET-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling File::sysopen()
Exception Message:
Failed to open the file 'RelVal_Raw_GRun_MC.root'
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] open() failed with system error 'No such file or directory' (error code 2)
----- End Fatal Exception -------------------------------------------------
Expand to see more addon errors ...

@abdoulline
Copy link
Author

Hm...m I don't see HFShowerLibrary_run3_v7.root
in
https://cmssdt.cern.ch/SDT/data/CMSSW/SimG4CMS/Calo/data/

@civanch
Copy link
Contributor

civanch commented Mar 2, 2023

Let us wait for the morning.

@abdoulline
Copy link
Author

v7 seems to be available in the latest IB:
/cvmfs/cms-ib.cern.ch/sw/x86_64/week0/slc7_amd64_gcc11/cms/cmssw/CMSSW_13_1_X_2023-03-02-2300/external/slc7_amd64_gcc11/data/SimG4CMS/Calo/data/

-rw-r--r--. 1 cvmfs cvmfs 1180292330 Mar 3 00:03 HFShowerLibrary_run3_v7.root
-rw-r--r--. 1 cvmfs cvmfs 1249815228 Mar 3 00:03 HFShowerLibrary_run3_v6.root
-rw-r--r--. 1 cvmfs cvmfs 190776418 Mar 3 00:03 HFShowerLibrary_oldpmt_noatt_eta4_16en_v3.root
-rw-r--r--. 1 cvmfs cvmfs 343223032 Mar 3 00:03 HFShowerLibrary_npmt_noatt_eta4_16en_v4.root

@smuzaffar
Copy link
Contributor

Hm...m I don't see HFShowerLibrary_run3_v7.root in https://cmssdt.cern.ch/SDT/data/CMSSW/SimG4CMS/Calo/data/

@abdoulline , these SL libs are very big (over 1GB) and we can not push these to github data repo (due to 100MB size limit). So for this data package we deploy data from http://cmsrep.cern.ch/cmssw/download/data/ . SL v7 is available in CMSSW_13_1_X_2023-03-02-2300.

@smuzaffar
Copy link
Contributor

please test

new SL v7 is available now in IB

@abdoulline
Copy link
Author

Hm...m I don't see HFShowerLibrary_run3_v7.root in https://cmssdt.cern.ch/SDT/data/CMSSW/SimG4CMS/Calo/data/

@abdoulline , these SL libs are very big (over 1GB) and we can not push these to github data repo (due to 100MB size limit). So for this data package we deploy data from http://cmsrep.cern.ch/cmssw/download/data/ . SL v7 is available in CMSSW_13_1_X_2023-03-02-2300.

I see, thanks!
Yes, I've noticed (above) that v7 has arrived in the latest IB.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a57f93/31021/summary.html
COMMIT: 6cf217e
CMSSW: CMSSW_13_1_X_2023-03-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40933/31021/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 16 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529699
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529675
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Mar 3, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants