Fix for nanoGEN jets

[Cvico]

PR description

This PR includes a minimal change in the configuration file that is used for producing NanoGEN format: PhysicsTools/NanoAOD/python/nanogen_cff.py.

Additional information

This issue has been known for some time, but it was never fixed and included in the master branch up until know. Everything regarding this issue is discussed in 1 and 2.

I'm adding @kdlong in the thread (since he is the one that told me the issue) just in case there's any other detail I might be leaving out. The changes to the central code should have 0 impact (just change the object that is used for computing generation jets), but the physics impact should be quite relevant specially for those analyses that use NanoGEN information for comparing generation jets between nanoGEN and nanoAOD.

References

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41163/34822

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

[cmsbuild]

A new Pull Request was created by @Cvico (Carlos Vico Villalba) for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @simonepigazzini, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swertz]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18d7ca/31577/summary.html
COMMIT: 61caf63
CMSSW: CMSSW_13_1_X_2023-03-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41163/31577/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 14 lines from the logs
• Reco comparison results: 15 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3554286
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3554255
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[kdlong]

Thanks @Cvico, it's nice to see this bug finally corrected.

[swertz]

+1

Thanks! Perhaps it could be good to also backport this to 13_0_X, in case people will use the same release for NanoGEN and NanoAOD v12...

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[Cvico]

Hi. Thanks for merging my PR!. Regarding the comment from @swertz,
if you think this would be good to backport, I can prepare it.

[swertz]

if you think this would be good to backport, I can prepare it.

Yes, I think it would be good to fix in 13_0 as well. Thanks!